Merge pull request #107 from BBVAEngineering/feature/shrink-config-en…

…vironment

Feature/shrink config environment

README.md

@@ -67,21 +67,23 @@ const app = new EmberAddon(defaults, {
 
 You can further customize ember-cli-workbox by setting **workbox configurations** in your `config/environment.js` on in your `ember-cli-build.js`
 
-*Note*: `importScriptsTransform` must be defined in your `ember-cli-build.js`.
+*Note*: `importScriptsTransform` and `workbox` must be defined in your `ember-cli-build.js`.
 
 ```javascript
-//app/config/environment.js
+//ember-cli-build.js
 
-ENV['workbox'] = {
-  globPatterns: [
-    '**\/*.{html,js,css}'
-  ],
+const app = new EmberAddon(defaults, {
+  workbox: {
+    globPatterns: [
+      '**\/*.{html,js,css}'
+    ],
 
-  globDirectory: './',
+    globDirectory: './',
 
-  globIgnores: [],
-  // ...
-};
+    globIgnores: [],
+    // ...
+  }
+});
 ```
 
 | Property                        | Description                                                                                                                                                                                                                                                                                                                                                                                                                                             |

addon/instance-initializers/sw.js

@@ -14,7 +14,7 @@ export function getConfig(appInstance) {
 	return {
 		isEnabled: getWithDefault(config, 'ember-cli-workbox.enabled', isProdBuild),
 		debugAddon: getWithDefault(config, 'ember-cli-workbox.debug', !isProdBuild),
-		swDestFile: getWithDefault(config, 'workbox.swDest', 'sw.js'),
+		swDestFile: getWithDefault(config, 'ember-cli-workbox.swDest', 'sw.js'),
 		autoRegister: getWithDefault(config, 'ember-cli-workbox.autoRegister', true)
 	};
 }

ember-cli-build.js

@@ -3,7 +3,11 @@
 const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
 
 module.exports = function(defaults) {
-	const app = new EmberAddon(defaults, {});
+	const app = new EmberAddon(defaults, {
+		workbox: {
+			swDest: 'sw.js'
+		}
+	});
 
 	// Use `app.import` to add additional libraries to the generated
 	// output files.

index.js

@@ -10,8 +10,9 @@ module.exports = {
 	isDevelopingAddon: () => true,
 
 	config(env, baseConfig) {
-		const workboxOptions = baseConfig.workbox || {};
-		const options = baseConfig['ember-cli-workbox'] || {};
+		const workboxOptions = this.app.options.workbox || {};
+		const emberCliWorkboxOptions = baseConfig['ember-cli-workbox'];
+		const options = emberCliWorkboxOptions || {};
 		const appOptions = this.app.options['ember-cli-workbox'] || {};
 		const projectName = baseConfig.APP && baseConfig.APP.name || 'app';
 
@@ -43,6 +44,11 @@ module.exports = {
 
 		this._options = options;
 		this.workboxOptions = workboxOptions;
+
+		// Append "workbox" config to "ember-cli-workbox" config
+		if (emberCliWorkboxOptions) {
+			emberCliWorkboxOptions.swDest = workboxOptions.swDest;
+		}
 	},
 
 	postprocessTree(type, tree) {

tests/acceptance/configuration-test.js

@@ -0,0 +1,19 @@
+import { module, test } from 'qunit';
+import { setupApplicationTest } from 'ember-qunit';
+
+module('Acceptance | Simple Acceptance Test', (hooks) => {
+	setupApplicationTest(hooks);
+
+	test('"workbox" configuration is not in environment config', async function(assert) {
+		const config = this.owner.resolveRegistration('config:environment');
+
+		assert.notOk(config.workbox);
+	});
+
+	test('"workbox" configuration is setted in "ember-cli-workbox" config object', async function(assert) {
+		const config = this.owner.resolveRegistration('config:environment');
+
+		assert.equal(config['ember-cli-workbox'].swDest, 'sw.js');
+	});
+});
+

tests/dummy/config/environment.js

@@ -9,9 +9,6 @@ module.exports = function(environment) {
 		'ember-cli-workbox': {
 			enabled: true
 		},
-		workbox: {
-			swDest: 'sw.js'
-		},
 		EmberENV: {
 			FEATURES: {
 				// Here you can enable experimental features on an ember canary build