Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llm_service.py #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update llm_service.py #120

wants to merge 2 commits into from

Conversation

iterateccvoelker
Copy link
Collaborator

  • improved LLM Formulation creation with more specific instructions and examples
  • update to new model GPT-4o
  • manually tested for multiple scenarios -> much improved output.

- improved Formulation creation with more specific instructions and examples
- update to new model GPT-4o
@iterateccvoelker iterateccvoelker added the enhancement New feature or request label May 21, 2024
Copy link
Collaborator

@RugTehseen RugTehseen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe es mal getestet und das Outputformat variiert. Die fachliche Qualität der Antworten kannst du aber deutlich besser bewerten als ich.

f"Based on the general knowledge, your task is to explicitly give a recipe which lists:\n"
f"## Weight of Powders: [your esitmate'] kg\n"
f"## W/C-Ratio: [your estimate] %\n"
f"## If relevant Weight of Additives [your esitmate] kg\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estimate ist falsch geschrieben (hier und in den Zeilen drunter

@@ -257,26 +264,17 @@ def _create_output_format_excerpt(cls):

For you orientation, here are some examples (note that these are just examples and must not be included in the general knowledge provided; further make sure to use units that are conventional for the components you are proposing):

Example 1:
Water to Cement Ratio: 0.5
Make sure to stick to exactly this format! Here are examples:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bei meinem ersten Test hat er sich nicht an das Format gehalten. Hier das Ergebnis (ich habe relativ viele Komponenten angehakt um auch komplexe Setups zu testen):

Based on the provided design guidelines and components, here is an optimized concrete formulation recipe: - Weight of Powders: 400 kg - Water to Binder Ratio: 35% - Weight of Additives (Biochar, Limestone Powder): 4 kg, 40 kg - Weight of Admixtures (Super Plasticizer): 4 kg - Composition of Powder Blend (Fly Ash/GGBFS): 60/40 - Composition of Liquid (H2O/Activator Liquid): 96/4 - Processing: standard mixing and vibrating, ambient curing - Aggregates: 1800 kg Let's include the components as a comma-separated list: - Weight of Powders: 400 kg - Water to Binder Ratio: 35% - Weight of Additives (Biochar): 4 kg - Weight of Additives (Limestone Powder): 40 kg - Weight of Admixtures (Super Plasticizer): 4 kg - Composition of Powder Blend (Fly Ash/GGBFS): 60/40 - Composition of Liquid (H2O/Activator Liquid): 96/4 - Processing: standard mixing and vibrating, ambient curing - Aggregates: 1800 kg

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auch bei einer einfacheren Komposition wurde das Format nicht eingehalten:

  • Weight of Powders: 400 kg - Water to Cement Ratio: 40 % - Weight of Recycled Aggregates: 1000 kg - Composition of Powder Blend Fly Ash/GGBFS: 60/40 - Composition of Liquid H2O: 100 % - Processing: standard concrete mixing and curing methods

Example 3:
Fly Ash: 40%, Water: 25%, Biochar: 10%, Rice Husk Ash: 10%, Recycled Glass Fines: 10%, Super Plasticizer: 5%
Example 3 Alkali Activated Binder Composition :
Fly Ash/GGBFS: 40/60, Water to Cement Ratio: 38 %, Biochar: 10%, Rice Husk Ash: 10%, Recycled Glass Fines: 10%, Super Plasticizer: 5%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dem File gibt es noch 2 print statements, die man entfernen kann

print(design_knowledge_prompt)

und

print(prompt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants