Fix deprecation warnings #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 23, 2021 15:04
… listed in Imports.
…n practice this just meant adding all packages this package actually needs to the DESCRIPTION file and explicitly importing those functions in the NAMESPACE file.
…he package and those functions explicitly.
…mmended replacement: install_unit. David will need to review this checkin carefully as the parameters he was setting in install_symbolic_unit do not seem to have exact replacements in install_unit.
…o use install_unit instead. Like the last checkin, David will have to review this one to make sure it is correct. My reading of the documentation is that "veh mi" is translated as multiplication. And since the offset in the old code was 1, I think that this should work. But I really don't know how to test this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1 (which in turn is part of BAAQMD/inventory#28).
In short, the production version of this package is using functions in the
unitspackage that are now deprecated. This PR attempts to replace those function calls with the listed replacements.@dholstius Please do a careful review of the changes (especially in
.onLoad). Since I haven't used this package myself before, and there is no obvious way to test the changes, it's important that someone make sure that the package still works as expected.Note that I made other changes while in the neighborhood. The package was missing a lot of necessary packages in
Importsthat I added. And I also removed a lot of notes and warnings when running R CMD check (removed 3 warnings and 2 notes - it still generates 3 warnings and 2 notes).