Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brk2.0_oracle_views.sql #2051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update brk2.0_oracle_views.sql #2051

wants to merge 1 commit into from

Conversation

KJLammers
Copy link
Contributor

N.a.v. support vraag geconstateerd dat in de Oracle versie van deze view op regel 508 gekeken werd naar een verkeerde tabel. Hierdoor waren alleen eigendomsrechten aan kadastrale onroerende zaken gekoppeld. Hiermee wordt dit probleem gefixed

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37%. Comparing base (b956f25) to head (32a04ef).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #2051    +/-   ##
=========================================
+ Coverage        37%     37%    +1%     
- Complexity      810     948   +138     
=========================================
  Files           415     415            
  Lines         21224   21224            
  Branches       2009    2009            
=========================================
+ Hits           7782    7783     +1     
  Misses        12824   12824            
+ Partials        618     617     -1     

see 1 file with indirect coverage changes

@mprins
Copy link
Member

mprins commented Mar 24, 2024

kennelijk vergeten in #1992

@mprins mprins marked this pull request as draft March 24, 2024 19:53
@KJLammers
Copy link
Contributor Author

Ik snap even niet zo goed waarom deze blijft hangen? Wat moet er gebeuren om hem in de master te krijgen?

N.a.v. support vraag geconstateerd dat in de Oracle versie van deze view op regel 508 gekeken werd naar een verkeerde tabel. Hierdoor waren alleen eigendomsrechten aan kadastrale onroerende zaken gekoppeld. Hiermee wordt dit probleem gefixed
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40%. Comparing base (1fcd550) to head (aad72fd).
Report is 128 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #2051    +/-   ##
=========================================
- Coverage        40%     40%    -0%     
- Complexity      807    1014   +207     
=========================================
  Files           371     371            
  Lines         18807   18807            
  Branches       1774    1774            
=========================================
- Hits           7493    7488     -5     
- Misses        10722   10726     +4     
- Partials        592     593     +1     

see 3 files with indirect coverage changes

@KJLammers KJLammers marked this pull request as ready for review June 11, 2024 10:46
@mprins
Copy link
Member

mprins commented Jul 4, 2024

Ik snap even niet zo goed waarom deze blijft hangen? Wat moet er gebeuren om hem in de master te krijgen?

https://b3partners.github.io/brmo/developer-notes.html#basisprocedure

Copy link

github-actions bot commented Sep 2, 2024

Dit PR is automatisch gemarkeerd als "stale" omdat er niet meer aan gewerkt wordt. Als er niets meer mee gebeurd zal deze PR automatisch worden gesloten.

@github-actions github-actions bot added the stale label Sep 2, 2024
@github-actions github-actions bot removed the stale label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants