Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change os.rename for shutil.move #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miguelpmachado
Copy link
Member

For filesystems compatibility

@miguelpmachado miguelpmachado self-assigned this Jul 15, 2019
Copy link
Member

@cimendes cimendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :) This is an atempt at resolving this type of error (https://stackoverflow.com/questions/42392600/oserror-errno-18-invalid-cross-device-link) but people are still reporting the same error. Still, moving from os.rename to shutil seems wise to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants