Upgrade to bevy 0.7 #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpence
commented
May 21, 2022
| @@ -44,7 +44,7 @@ pub(crate) struct SpriteData<T> { | |||
| } | |||
| impl SpriteData<Image> { | |||
| pub(crate) fn new(ase: &AsepriteFile, frame: u32) -> Self { | |||
| let img = ase.frame(frame).image(); | |||
| let img = &ase.frame(frame).image(); | |||
There was a problem hiding this comment.
I don't know why I did this, I'll look into that
| @@ -77,16 +77,16 @@ fn spawn_tiles( | |||
| ) { | |||
| for (_, tileset) in tilesets.iter() { | |||
| let texture_handle = tileset.texture.clone(); | |||
| let material_handle = materials.add(ColorMaterial::texture(texture_handle)); | |||
| //let material_handle = materials.add(ColorMaterial::from(texture_handle)); | |||
There was a problem hiding this comment.
I didn't mean to leave these comments in.
|
|
||
| let (mut layer_builder, layer_entity) = | ||
| LayerBuilder::<TileBundle>::new(&mut commands, settings, 0u16, 0u16); | ||
|
|
||
| set_tiles(&mut layer_builder); | ||
|
|
||
| map_query.build_layer(&mut commands, layer_builder, material_handle); | ||
| map_query.build_layer(&mut commands, layer_builder, texture_handle); |
There was a problem hiding this comment.
I changed these because build_layer doesn't accept ColorMaterial. I made this change quickly without understanding what the example is trying to do, I'll fix it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't finished yet because for some reason the tilemap example doesn't work, it just shows a gray screen.
This message from bevy_ecs_tilemap gets printed over and over:
I haven't looked into why this happens yet.