This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
[WIP] Support Microsoft apps on v2 endpoint #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but WIP because I could use some feedback, and also the README will need to be updated before this is merged.
Summary
#callback_phase
, easier options etc.)'common'
as the default tenant.info
to only include claims that are present in v2 id tokensc_hash
is not always present, only validatec_hash
if it's present in the id token.verify_iss
is defaulted tofalse
because in my case I didn't need to verify the iss (it can either be the user's tenant ID if using an Azure AD account or9188040d-6c67-4c5b-b112-36a304b66dad
for Microsoft personal accounts, if I understand correctly). This will probably need an update to work for someone who needs to verify a specificiss
. I may be able to investigate this a little later.For reference: https://docs.microsoft.com/en-us/azure/active-directory/develop/id-tokens#v20