Lozensky/perf fix graph service client (#3251)

* Moving validator to static member
AzureAD · Feb 22, 2025 · bbe8494 · bbe8494
1 parent ae4211e
commit bbe8494
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/Microsoft.Identity.Web.GraphServiceClient/GraphAuthenticationProvider.cs b/src/Microsoft.Identity.Web.GraphServiceClient/GraphAuthenticationProvider.cs
@@ -23,7 +23,7 @@ internal class GraphAuthenticationProvider : IAuthenticationProvider
         private const string AuthorizationHeaderKey = "Authorization";
         readonly IAuthorizationHeaderProvider _authorizationHeaderProvider;
         readonly GraphServiceClientOptions _defaultAuthenticationOptions;
-        private readonly string[] _graphUris = ["graph.microsoft.com", "graph.microsoft.us", "dod-graph.microsoft.us", "graph.microsoft.de", "microsoftgraph.chinacloudapi.cn", "canary.graph.microsoft.com", "graph.microsoft-ppe.com"];
+        private static readonly AllowedHostsValidator _allowedGraphHostsValidator = new(["graph.microsoft.com", "graph.microsoft.us", "dod-graph.microsoft.us", "graph.microsoft.de", "microsoftgraph.chinacloudapi.cn", "canary.graph.microsoft.com", "graph.microsoft-ppe.com"]);
         readonly IEnumerable<string> _defaultGraphScope = ["https://graph.microsoft.com/.default"];
 
         /// <summary>
@@ -83,9 +83,8 @@ public async Task AuthenticateRequestAsync(
                 authorizationHeaderProviderOptions = graphServiceClientOptions;
             }
 
-            AllowedHostsValidator allowedHostsValidator = new(_graphUris);
             // Add the authorization header
-            if (allowedHostsValidator.IsUrlHostValid(request.URI) && !request.Headers.ContainsKey(AuthorizationHeaderKey))
+            if (_allowedGraphHostsValidator.IsUrlHostValid(request.URI) && !request.Headers.ContainsKey(AuthorizationHeaderKey))
             {
                 string authorizationHeader = await _authorizationHeaderProvider.CreateAuthorizationHeaderAsync(
                         authorizationHeaderProviderOptions!.RequestAppToken ? _defaultGraphScope : scopes!,

diff --git a/tests/E2E Tests/GraphServiceClientTests/GraphServiceClientTests.cs b/tests/E2E Tests/GraphServiceClientTests/GraphServiceClientTests.cs
@@ -66,7 +66,6 @@ async Task TestAsync()
                     o.RequestAppToken = true;
                 });
             });
-
         }
 
         [Fact]
-Original file line number
+Diff line change
@@ Expand Up / @@ -66,7 +66,6 @@ async Task TestAsync() @@
                         o.RequestAppToken = true;
                     });
                 });
             }
             [Fact]
@@ Expand Down @@