removed equals and gethashcode

AzureAD · Dec 1, 2023 · d83afd2 · d83afd2
1 parent e560977
commit d83afd2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 29 deletions.
diff --git a/src/Microsoft.Identity.Abstractions/ManagedIdentity/ManagedIdentityOptions.cs b/src/Microsoft.Identity.Abstractions/ManagedIdentity/ManagedIdentityOptions.cs
@@ -33,34 +33,9 @@ public ManagedIdentityOptions Clone()
         {
             return new ManagedIdentityOptions
             {
-                ManagedIdentityType = this.ManagedIdentityType,
-                ClientId = this.ClientId
+                ManagedIdentityType = ManagedIdentityType,
+                ClientId = ClientId
             };
         }
-
-        /// <summary>
-        /// Ensures any <see cref="ManagedIdentityOptions"/> object is equal if all fields hold the same values.
-        /// </summary>
-        /// <param name="obj"></param>
-        /// <returns></returns>
-        public override bool Equals(object obj)
-        {
-            if (obj == null || GetType() != obj.GetType())
-            {
-                return false;
-            }
-            ManagedIdentityOptions other = (ManagedIdentityOptions)obj;
-            return ManagedIdentityType == other.ManagedIdentityType &&
-                ClientId == other.ClientId;
-        }
-
-        /// <summary>
-        /// Returns the hash code for the instance based on the values of its fields.
-        /// </summary>
-        /// <returns>A 32-bit signed integer hash code.</returns>
-        public override int GetHashCode()
-        {
-            return new { ManagedIdentityType, ClientId }.GetHashCode();
-        }
     }
 }
diff --git a/test/Microsoft.Identity.Abstractions.Tests/DownstreamApiTests.cs b/test/Microsoft.Identity.Abstractions.Tests/DownstreamApiTests.cs
@@ -76,7 +76,8 @@ public void CloneClonesAllProperties()
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.ExtraQueryParameters, downstreamApiClone.AcquireTokenOptions.ExtraQueryParameters);
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.ForceRefresh, downstreamApiClone.AcquireTokenOptions.ForceRefresh);
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.LongRunningWebApiSessionKey, downstreamApiClone.AcquireTokenOptions.LongRunningWebApiSessionKey);
-            Assert.Equal(downstreamApiOptions.AcquireTokenOptions.ManagedIdentity, downstreamApiClone.AcquireTokenOptions.ManagedIdentity);
+            Assert.Equal(downstreamApiOptions.AcquireTokenOptions.ManagedIdentity.ManagedIdentityType, downstreamApiClone.AcquireTokenOptions.ManagedIdentity.ManagedIdentityType);
+            Assert.Equal(downstreamApiOptions.AcquireTokenOptions.ManagedIdentity.ClientId, downstreamApiClone.AcquireTokenOptions.ManagedIdentity.ClientId);
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.PopPublicKey, downstreamApiClone.AcquireTokenOptions.PopPublicKey);
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.PopClaim, downstreamApiClone.AcquireTokenOptions.PopClaim);
             Assert.Equal(downstreamApiOptions.AcquireTokenOptions.Tenant, downstreamApiClone.AcquireTokenOptions.Tenant);
@@ -154,4 +155,4 @@ public CustomAcquireTokenOptions() : base() { }
 
         public CustomAcquireTokenOptions(CustomAcquireTokenOptions other) : base(other) { }
     }
-}
+}