Native authentication extensibility #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhMSFT
reviewed
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/ResetPasswordErrors.kt
Outdated
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplication.kt
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplication.kt
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/ResetPasswordErrors.kt
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/SignInErrors.kt
Show resolved
Hide resolved
SammyO
requested changes
Dec 14, 2023
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/Error.kt
Outdated
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/SignUpErrors.kt
Show resolved
Hide resolved
.../src/main/java/com/microsoft/identity/nativeauth/statemachine/results/ResetPasswordResult.kt
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/AccountState.kt
Outdated
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/Callback.kt
Outdated
Show resolved
Hide resolved
| @@ -82,6 +72,16 @@ import com.microsoft.identity.common.java.providers.microsoft.azureactivedirecto | |||
| import com.microsoft.identity.common.java.util.ResultFuture | |||
| import com.microsoft.identity.common.java.util.StringUtil | |||
| import com.microsoft.identity.common.java.nativeauth.util.checkAndWrapCommandResultType | |||
| import com.microsoft.identity.nativeauth.statemachine.errors.ErrorTypes | |||
There was a problem hiding this comment.
Shouldn't this PR also contain updated tests?
There was a problem hiding this comment.
This PR should contain updated tests. Previously the test branch had not been merged and the test files did not exist. Now it has been updated.
SaurabhMSFT
reviewed
Dec 14, 2023
SaurabhMSFT
approved these changes
Dec 14, 2023
SammyO
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check https://identitydivision.visualstudio.com/Engineering/_git/devexdub-android-msal-native-auth-private-clone/pullrequest/10864 for detail