Native auth extensibility #1968

Yuki-YuXin · 2023-12-04T17:26:02Z

Include those commits

The code in this pull request is for the base work needed to support Signup, SignIn and SSPR features for Native Auth. Any class that is used by at least two of the features has been included in this pull request. This pull request introduces kotlin co routines libraries as dependencies for msal and its associated test project. Further mockk, mockito libraries have been added as dependencies for test projects. A companion PR in the MSAL Common repository is AzureAD/microsoft-authentication-library-common-for-android#2166

ciam-feature will be update to 82f5153 commit of dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]>

ciam-feature is updated to 991c541 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]>

This PR includes the work for SignIn relates features of Native Auth Companion PR in MSAL Common repo is AzureAD/microsoft-authentication-library-common-for-android#2207

This PR includes the work for Signup related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL Common is AzureAD/microsoft-authentication-library-common-for-android#2229

ciam-feature is updated to 9735ed9 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]> Co-authored-by: Neha Goel <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: pedro romero vargas <[email protected]>

This PR includes the work for self service password reset related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL is AzureAD/microsoft-authentication-library-common-for-android#2230

…it/devexdub-android-msal-native-auth-private-clone/commit/7edb31fe71168b133d0c2db7d70c65ae3fb4d8f6?refName=refs/heads/sdk-extensibility/sdk-extensibility-feature-branch&path=/msal/src/main/java/com/microsoft/identity/client/statemachine/results/SignUpResult.kt

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/825d7c77e22a9f6be39e284cfa7b9e14d8429572?refName=refs%2Fheads%2Fsdk-extensibility%2Fsdk-extensibility-feature-branch&path=%2Fmsal%2Fsrc%2Ftest%2Fjava%2Fcom%2Fmicrosoft%2Fidentity%2Fclient%2Fnativeauth%2FNativeAuthPublicClientApplicationKotlinTest.kt

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/f00673a54744405786d0ba02ccd33eb60f624758?refName=refs/heads/sdk-extensibility/sdk-extensibility-feature-branch&path=/msal/src/test/java/com/microsoft/identity/client/nativeauth/NativeAuthPublicClientApplicationKotlinTest.kt

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/aad721ea1c934ba7158893b262c0365bd3266259?refName=refs%2Fheads%2Fsdk-extensibility%2Fsdk-extensibility-feature-branch

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/5c74f30e9990f1271b208f663cc2d8016bc562e1?refName=refs%2Fheads%2Fsdk-extensibility%2Fsdk-extensibility-feature-branch

This reverts commit c4a1822.

This reverts commit fffc834.

SammyO · 2023-12-11T12:13:53Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/SignUpStates.kt

@@ -62,14 +63,6 @@ import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import java.io.Serializable

-/**


Why were these comments removed?

SammyO · 2023-12-11T12:14:15Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/SignUpStates.kt

                    )
                }
            }
        }
    }
 }

-/**
- * Native Auth uses a state machine to denote state and transitions for a user.


SammyO · 2023-12-11T12:14:23Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/SignUpStates.kt

@@ -454,14 +425,6 @@ class SignUpPasswordRequiredState internal constructor(
    }
 }

-/**
- * Native Auth uses a state machine to denote state and transitions for a user.


SammyO · 2023-12-11T12:14:31Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/SignUpStates.kt

                    )
                }
            }
        }
    }
 }

-/**
- * Native Auth uses a state machine to denote state and transitions for a user.


SaurabhMSFT · 2023-12-08T10:08:54Z

msal/src/main/java/com/microsoft/identity/client/statemachine/results/SignUpResult.kt

 import com.microsoft.identity.client.statemachine.states.SignInAfterSignUpState
 import com.microsoft.identity.client.statemachine.states.SignUpAttributesRequiredState
 import com.microsoft.identity.client.statemachine.states.SignUpCodeRequiredState
 import com.microsoft.identity.client.statemachine.states.SignUpPasswordRequiredState

 /**
- * Sign up result, produced by
+ * Results for native sign up flows.
+ * TODO add documentation & links to learn.microsoft.com


can you remove this todo?

SaurabhMSFT · 2023-12-13T16:14:24Z

msal/src/main/java/com/microsoft/identity/client/INativeAuthPublicClientApplication.kt

@@ -109,66 +109,15 @@ interface INativeAuthPublicClientApplication : IPublicClientApplication {
     */
    fun signInUsingPassword(username: String, password: CharArray, scopes: List<String>? = null, callback: NativeAuthPublicClientApplication.SignInUsingPasswordCallback)

-    /**


Can you restore deleted comments from this file?

SaurabhMSFT · 2023-12-13T16:23:43Z

msal/src/main/java/com/microsoft/identity/client/NativeAuthPublicClientApplication.kt

@@ -343,38 +323,53 @@ class NativeAuthPublicClientApplication(
                        )
                    )
                }
-                is SignInCommandResult.InvalidCredentials -> {
+                is SignInCommandResult.Complete -> {


We can merge the clauses for Complete, InvalidCredentials and UnknownError into else block. Or at least Complete, InvalidCredentials can be merged into a single else block.

SaurabhMSFT · 2023-12-13T16:31:24Z

msal/src/main/java/com/microsoft/identity/client/statemachine/results/ResetPasswordResult.kt

 import com.microsoft.identity.client.statemachine.states.ResetPasswordCodeRequiredState
 import com.microsoft.identity.client.statemachine.states.ResetPasswordPasswordRequiredState

+/**
+ * Results for native Self-service password reset flows.
+ * TODO add documentation & links to learn.microsoft.com


We should remove this TODO as the link to documentation has been added below.

SaurabhMSFT · 2023-12-13T16:32:31Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/BaseStates.kt


 /**
 * BaseState is the base class for various states in the Native Auth state machine.
 */
-abstract class BaseState(internal open val flowToken: String?)
+abstract class BaseState(internal open val flowToken: String?)


New line should be added at the end.

SaurabhMSFT · 2023-12-13T16:32:46Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/ResetPasswordStates.kt

@@ -55,13 +56,6 @@ import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import java.io.Serializable

-/**


Can you restore this comment

SaurabhMSFT · 2023-12-13T16:33:00Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/ResetPasswordStates.kt

                    )
                }
            }
        }
    }

-    /**
-     * ResendCodeCallback receives the result for submit code for Reset Password for Native Auth


Can you restore this comment

SaurabhMSFT · 2023-12-13T16:33:10Z

msal/src/main/java/com/microsoft/identity/client/statemachine/states/ResetPasswordStates.kt

                    )
                }
            }
        }
    }
 }

-/**
- * Native Auth uses a state machine to denote state and transitions for a user.


Can you restore this comment?

SaurabhMSFT · 2023-12-13T16:41:25Z

...c/test/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplicationJavaTest.java

@@ -258,7 +270,11 @@ public void onError(@NonNull BaseException exception) {
        };
        application.signInUsingPassword(username, password, null, callback);
        // 1a. Server returns invalid password error
-        assertTrue(signInResult.get(30, TimeUnit.SECONDS) instanceof SignInResult.InvalidCredentials);
+        SignInUsingPasswordResult result = signInResult.get(30, TimeUnit.SECONDS);
+        assertTrue(result instanceof SignInUsingPasswordError);


We should avoid using assertTrue where we are no comparing a boolean object. If assertTrue fails in this case then we won't know from the test run about the actual class of result. Below shows an example using assertThat

https://stackoverflow.com/questions/12404650/assert-an-object-is-a-specific-type

SaurabhMSFT and others added 13 commits October 3, 2023 19:35

SignIn code for Native Auth (#1919)

872c867

This PR includes the work for SignIn relates features of Native Auth Companion PR in MSAL Common repo is AzureAD/microsoft-authentication-library-common-for-android#2207

One

8a61cd2

Use parameter for testing

cfadd2f

Remove todo

cb62294

Yuki-YuXin requested review from SammyO, SaurabhMSFT and GBakolas December 4, 2023 17:26

Yuki-YuXin requested a review from a team as a code owner December 4, 2023 17:26

github-actions bot added the msal label Dec 4, 2023

Yuki-YuXin added 2 commits December 4, 2023 17:37

Please check commit https://identitydivision.visualstudio.com/Enginee…

ec9bb3e

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/aad721ea1c934ba7158893b262c0365bd3266259?refName=refs%2Fheads%2Fsdk-extensibility%2Fsdk-extensibility-feature-branch

Please check commit https://identitydivision.visualstudio.com/Enginee…

d05b804

…ring/_git/devexdub-android-msal-native-auth-private-clone/commit/5c74f30e9990f1271b208f663cc2d8016bc562e1?refName=refs%2Fheads%2Fsdk-extensibility%2Fsdk-extensibility-feature-branch

Yuki-YuXin changed the base branch from saugautam/2642915 to dev December 6, 2023 10:45

SaurabhMSFT added 2 commits December 7, 2023 12:40

Merge branch 'dev' into saugautam/2642915

2c2937c

Resolve merge

a59e4d1

Yuki-YuXin closed this Dec 7, 2023

Yuki-YuXin reopened this Dec 7, 2023

Yuki-YuXin changed the base branch from dev to saugautam/2642915 December 7, 2023 15:16

SaurabhMSFT and others added 4 commits December 7, 2023 17:42

Include powermock dependency

be19cd7

Merge branch 'saugautam/2642915' into native-auth-extensibility

16e76c6

Ignoring tests for build

c4a1822

Revert "Ignoring tests for build"

69f3cdc

This reverts commit c4a1822.

SaurabhMSFT added 4 commits December 8, 2023 18:57

Restore one file

fffc834

Revert "Restore one file"

216698f

This reverts commit fffc834.

Changes from test branch

75eabaf

Update pointer

375fd45

SammyO reviewed Dec 11, 2023

View reviewed changes

Merge branch 'saugautam/2642915' into native-auth-extensibility

40bb2db

SaurabhMSFT requested changes Dec 13, 2023

View reviewed changes

Base automatically changed from saugautam/2642915 to dev December 13, 2023 16:48

SaurabhMSFT requested a review from a team as a code owner December 13, 2023 16:48

Yuki-YuXin closed this Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native auth extensibility #1968

Native auth extensibility #1968

Yuki-YuXin commented Dec 4, 2023

SammyO Dec 11, 2023

SammyO Dec 11, 2023

SammyO Dec 11, 2023

SammyO Dec 11, 2023

SaurabhMSFT Dec 8, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

SaurabhMSFT Dec 13, 2023

Native auth extensibility #1968

Native auth extensibility #1968

Conversation

Yuki-YuXin commented Dec 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment