Add unit tests for Native Auth #1966

SaurabhMSFT · 2023-11-30T17:42:20Z

This PR adds unit tests for Native Auth. No new dependency has been added.

The code in this pull request is for the base work needed to support Signup, SignIn and SSPR features for Native Auth. Any class that is used by at least two of the features has been included in this pull request. This pull request introduces kotlin co routines libraries as dependencies for msal and its associated test project. Further mockk, mockito libraries have been added as dependencies for test projects. A companion PR in the MSAL Common repository is AzureAD/microsoft-authentication-library-common-for-android#2166

ciam-feature will be update to 82f5153 commit of dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]>

ciam-feature is updated to 991c541 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]>

This PR includes the work for SignIn relates features of Native Auth Companion PR in MSAL Common repo is AzureAD/microsoft-authentication-library-common-for-android#2207

This PR includes the work for Signup related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL Common is AzureAD/microsoft-authentication-library-common-for-android#2229

ciam-feature is updated to 9735ed9 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]> Co-authored-by: Neha Goel <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: pedro romero vargas <[email protected]>

This PR includes the work for self service password reset related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL is AzureAD/microsoft-authentication-library-common-for-android#2230

...java/com/microsoft/identity/client/nativeauth/NativeAuthPublicClientApplicationJavaTest.java

...java/com/microsoft/identity/client/nativeauth/NativeAuthPublicClientApplicationKotlinTest.kt

This reverts commit c4a1822.

This reverts commit fffc834.

SaurabhMSFT · 2023-12-13T14:07:49Z

msal/src/main/java/com/microsoft/identity/client/PublicClientApplication.java

@@ -842,6 +842,8 @@ public static INativeAuthPublicClientApplication createNativeAuthPublicClientApp
                    null,
                    null
            );
+        }  catch (MsalException e) {


MsalException is a type of BaseException. The below clause was converting all MsalExceptions into unknown MsalException.

SammyO · 2023-12-13T14:34:40Z

.../src/androidTest/java/com/microsoft/identity/client/NativeAuthPublicApplicationKotlinTest.kt

+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+//  THE SOFTWARE.
+package com.microsoft.identity.client


Should be in dedicated native auth folder

and we should update code owners with this path

SammyO · 2023-12-13T14:36:37Z

azure-pipelines/pull-request-validation/pr-msal.yml

@@ -62,7 +62,13 @@ jobs:
  - task: Gradle@2
    displayName: Run Unit tests
    inputs:
-      tasks: msal:testLocalDebugUnitTest -Plabtest -ProbolectricSdkVersion=${{variables.robolectricSdkVersion}}
+      tasks: msal:testLocalDebugUnitTest -Plabtest -ProbolectricSdkVersion=${{variables.robolectricSdkVersion}} --tests *com.microsoft.identity.client*


@shahzaibj and @fadidurah can you review this? As this is a change to your test configuration, CI, etc.

I haven't seen --tests used before, but i'm guessing you're just spliting the test suite into native auth and non-native auth, which seems fine to me

yes, this runs tests in the specified package.

SaurabhMSFT and others added 8 commits October 3, 2023 19:35

SignIn code for Native Auth (#1919)

872c867

This PR includes the work for SignIn relates features of Native Auth Companion PR in MSAL Common repo is AzureAD/microsoft-authentication-library-common-for-android#2207

One

8a61cd2

github-actions bot added the msal label Nov 30, 2023

Use parameter for testing

cfadd2f

SaurabhMSFT marked this pull request as ready for review December 1, 2023 16:17

SaurabhMSFT requested a review from a team as a code owner December 1, 2023 16:17

Remove todo

cb62294

fadidurah reviewed Dec 4, 2023

View reviewed changes

...java/com/microsoft/identity/client/nativeauth/NativeAuthPublicClientApplicationJavaTest.java Outdated Show resolved Hide resolved

fadidurah reviewed Dec 4, 2023

View reviewed changes

...java/com/microsoft/identity/client/nativeauth/NativeAuthPublicClientApplicationKotlinTest.kt Outdated Show resolved Hide resolved

fadidurah approved these changes Dec 4, 2023

View reviewed changes

SaurabhMSFT added 3 commits December 7, 2023 12:40

Merge branch 'dev' into saugautam/2642915

2c2937c

Resolve merge

a59e4d1

Include powermock dependency

be19cd7

SaurabhMSFT changed the base branch from ciam-feature to dev December 8, 2023 11:56

SaurabhMSFT added the No-Changelog This change does not update the changelog. label Dec 8, 2023

SaurabhMSFT added 9 commits December 8, 2023 17:35

Ignoring tests for build

c4a1822

Revert "Ignoring tests for build"

69f3cdc

This reverts commit c4a1822.

Restore one file

fffc834

Revert "Restore one file"

216698f

This reverts commit fffc834.

Changes from test branch

75eabaf

Update pointer

375fd45

Merge branch 'dev' into saugautam/2642915

d409ca6

Merge branch 'dev' into saugautam/2642915

31d412e

Fix imports

66814d2

SaurabhMSFT requested a review from a team as a code owner December 13, 2023 11:36

SaurabhMSFT added 2 commits December 13, 2023 14:02

Fix androidTest

b18d6f7

Merge branch 'dev' into saugautam/2642915

737d66f

SaurabhMSFT commented Dec 13, 2023

View reviewed changes

SammyO reviewed Dec 13, 2023

View reviewed changes

Move native auth instrumented tests into separate folder

36f5de5

SammyO approved these changes Dec 13, 2023

View reviewed changes

SaurabhMSFT merged commit 26656d8 into dev Dec 13, 2023
9 checks passed

SaurabhMSFT deleted the saugautam/2642915 branch December 13, 2023 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests for Native Auth #1966

Add unit tests for Native Auth #1966

SaurabhMSFT commented Nov 30, 2023

SaurabhMSFT Dec 13, 2023 •

edited

Loading

SammyO Dec 13, 2023

SammyO Dec 13, 2023

SammyO Dec 13, 2023

fadidurah Dec 13, 2023

SaurabhMSFT Dec 13, 2023

Add unit tests for Native Auth #1966

Add unit tests for Native Auth #1966

Conversation

SaurabhMSFT commented Nov 30, 2023

SaurabhMSFT Dec 13, 2023 • edited Loading

Choose a reason for hiding this comment

SammyO Dec 13, 2023

Choose a reason for hiding this comment

SammyO Dec 13, 2023

Choose a reason for hiding this comment

SammyO Dec 13, 2023

Choose a reason for hiding this comment

fadidurah Dec 13, 2023

Choose a reason for hiding this comment

SaurabhMSFT Dec 13, 2023

Choose a reason for hiding this comment

SaurabhMSFT Dec 13, 2023 •

edited

Loading