Native Auth SignIn, Signup and SSPR features #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in this pull request is for the base work needed to support Signup, SignIn and SSPR features for Native Auth. Any class that is used by at least two of the features has been included in this pull request. This pull request introduces kotlin co routines libraries as dependencies for msal and its associated test project. Further mockk, mockito libraries have been added as dependencies for test projects. A companion PR in the MSAL Common repository is AzureAD/microsoft-authentication-library-common-for-android#2166
ciam-feature will be update to 82f5153 commit of dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]>
ciam-feature is updated to 991c541 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]>
This PR includes the work for SignIn relates features of Native Auth Companion PR in MSAL Common repo is AzureAD/microsoft-authentication-library-common-for-android#2207
This PR includes the work for Signup related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL Common is AzureAD/microsoft-authentication-library-common-for-android#2229
ciam-feature is updated to 9735ed9 commit from dev branch --------- Co-authored-by: melissaahn <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: yixilin <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dean Xu <[email protected]> Co-authored-by: Neha Goel <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: pedro romero vargas <[email protected]>
This PR includes the work for self service password reset related features of Native Auth. No new dependencies have been added as part of this PR. A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in MSAL is AzureAD/microsoft-authentication-library-common-for-android#2230
SaurabhMSFT
changed the title
fadidurah
reviewed
Dec 1, 2023
fadidurah
reviewed
Dec 4, 2023
msal/src/main/java/com/microsoft/identity/client/PublicClientApplication.java
Show resolved
Hide resolved
fadidurah
reviewed
Dec 4, 2023
msal/src/main/java/com/microsoft/identity/client/AccountAdapter.java
Outdated
Show resolved
Hide resolved
fadidurah
reviewed
Dec 4, 2023
msal/src/main/java/com/microsoft/identity/client/PublicClientApplication.java
Show resolved
Hide resolved
fadidurah
approved these changes
Dec 4, 2023
shahzaibj
approved these changes
Dec 5, 2023
SaurabhMSFT
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Dec 6, 2023
This PR is to merge the SignIn, Signup and other common code into dev branch. This code was previously reviewed in #2166, #2207 and #2229 A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview A companion PR in common repo is AzureAD/microsoft-authentication-library-for-android#1947 --------- Co-authored-by: pedro romero vargas <[email protected]> Co-authored-by: melissaahn <[email protected]> Co-authored-by: fadidurah <[email protected]> Co-authored-by: Dome Pongmongkol <[email protected]> Co-authored-by: iamgusain <[email protected]> Co-authored-by: DongXu <[email protected]> Co-authored-by: Sowmya Malayanur <[email protected]> Co-authored-by: Mohit <[email protected]> Co-authored-by: Sandesh Kumar Srivastava <[email protected]> Co-authored-by: tanmaymanolkar1 <[email protected]> Co-authored-by: amoyixi <[email protected]> Co-authored-by: Yixi Lin <[email protected]> Co-authored-by: Shahzaib <[email protected]>
iamgusain
added a commit
that referenced
this pull request
Jan 3, 2024
#1947 added a duplicate dependency for testUtils project. This causes failure to run UTs in monthly pipeline, [Example run](https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1229805&view=logs&j=f84464c4-dbde-50dc-0e4a-70f8148db754&t=f5fe7ea9-b05a-52f9-d231-7977d552c77d) Removing the duplicate dependency in this change, as testUtils dependency is already added for local and dist variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge the SignIn, SIgnup and SSPR code into dev branch. This code was previously reviewed in #1897, #1919, #1949 and #1950 .
A technical overview of Native Auth is available at https://dev.azure.com/IdentityDivision/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Native%20authentication/technical_overview.md&version=GBsammy/native-authentication&_a=preview
A companion PR in common repo is AzureAD/microsoft-authentication-library-common-for-android#2233