-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testcase2582290 testcase2582291 Test Case 2582288 Test Case 2582289 #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoyixi
changed the title
testcase2582290 and testcase2582291.
testcase2582290 testcase2582291 Test Case 2582288 Test Case 2582289
Aug 9, 2023
…msalautomationapp since they're not using adal
fadidurah
reviewed
Aug 10, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582288.java
Outdated
Show resolved
Hide resolved
fadidurah
reviewed
Aug 10, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582288.java
Outdated
Show resolved
Hide resolved
fadidurah
reviewed
Aug 10, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582290.java
Outdated
Show resolved
Hide resolved
fadidurah
reviewed
Aug 10, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582291.java
Outdated
Show resolved
Hide resolved
fadidurah
approved these changes
Aug 10, 2023
somalaya
reviewed
Aug 15, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582288.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Aug 15, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582288.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Aug 15, 2023
.../com/microsoft/identity/client/msal/automationapp/testpass/msalonly/ltw/TestCase2582289.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
somalaya
reviewed
Aug 26, 2023
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582290.java
Show resolved
Hide resolved
somalaya
reviewed
Aug 26, 2023
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582290.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Aug 26, 2023
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582290.java
Outdated
Show resolved
Hide resolved
somalaya
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make a separate folder for ltw test cases
this pr is about these four test cases:
Test Case 2582290: If LTW is the active broker, and request is made through Authenticator from MSAL in non-shared device mode, nothing should break
Test Case 2582291: If LTW is the active broker, and request is made through CP from MSAL in non-shared device mode, nothing should break
Test Case 2582288: If LTW is the active broker, and request is made through Authenticator from OneAuth, nothing should break
Test Case 2582289: If LTW is the active broker, and request is made through CP from OneAuth, nothing should break