Skip to content

Commit

Permalink
Ignore 497038 (#2170)
Browse files Browse the repository at this point in the history
This test shouldn't be ran in automation, as it relies on ui elements in
Outlook's mobile website's front page, which is constantly changing and
causing this test to break. We will run this manually during release
process.
  • Loading branch information
fadidurah authored Sep 5, 2024
1 parent db1a97e commit ba66d74
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common
Submodule common updated 34 files
+8 −1 changelog.txt
+1 −0 common/build.gradle
+2 −2 common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java
+1 −0 .../microsoft/identity/common/internal/broker/ipc/AccountManagerBackupIpcStrategyTargetingSpecificBrokerApp.kt
+5 −2 common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/IpcStrategyWithBackup.kt
+39 −10 common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java
+150 −10 common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java
+200 −0 common/src/test/java/com/microsoft/identity/common/internal/request/MsalBrokerResultAdapterTests.kt
+7 −0 common4j/src/main/com/microsoft/identity/common/java/AuthenticationConstants.java
+21 −4 common4j/src/main/com/microsoft/identity/common/java/controllers/ExceptionAdapter.java
+5 −0 common4j/src/main/com/microsoft/identity/common/java/exception/ClientException.java
+11 −0 common4j/src/main/com/microsoft/identity/common/java/exception/ErrorStrings.java
+40 −0 common4j/src/main/com/microsoft/identity/common/java/exception/InsufficientDeviceRegistrationException.java
+40 −0 common4j/src/main/com/microsoft/identity/common/java/exception/StrongDeviceRegistrationRequiredException.java
+6 −1 common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java
+1 −1 common4j/src/main/com/microsoft/identity/common/java/jwt/AbstractJwtRequest.java
+3 −0 common4j/src/main/com/microsoft/identity/common/java/jwt/JwtRequestBody.java
+16 −0 common4j/src/main/com/microsoft/identity/common/java/net/HttpResponse.java
+37 −5 common4j/src/main/com/microsoft/identity/common/java/net/UrlConnectionHttpClient.java
+6 −1 common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java
+3 −1 common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java
+23 −10 common4j/src/main/com/microsoft/identity/common/java/providers/RawAuthorizationResult.java
+7 −0 ...4j/src/main/com/microsoft/identity/common/java/providers/microsoft/MicrosoftAuthorizationErrorResponse.java
+2 −1 ...crosoft/identity/common/java/providers/microsoft/microsoftsts/AbstractMicrosoftStsTokenResponseHandler.java
+1 −9 ...rc/main/com/microsoft/identity/common/java/providers/microsoft/microsoftsts/MicrosoftStsOAuth2Strategy.java
+5 −0 common4j/src/main/com/microsoft/identity/common/java/providers/oauth2/AuthorizationErrorResponse.java
+19 −4 common4j/src/main/com/microsoft/identity/common/java/providers/oauth2/AuthorizationResultFactory.java
+8 −24 common4j/src/main/com/microsoft/identity/common/java/providers/oauth2/ITokenResponseHandler.java
+16 −1 common4j/src/main/com/microsoft/identity/common/java/providers/oauth2/OAuth2Strategy.java
+11 −0 common4j/src/test/com/microsoft/identity/common/java/net/HttpResponseTests.java
+60 −0 ...est/com/microsoft/identity/common/java/providers/microsoft/microsoftsts/MicrosoftStsOAuth2StrategyTest.java
+32 −1 common4j/src/test/com/microsoft/identity/common/java/providers/oauth2/OAuth2StrategyTest.java
+232 −0 testutils/src/main/java/com/microsoft/identity/internal/testutils/MockRecords.kt
+1 −1 testutils/src/main/java/com/microsoft/identity/internal/testutils/mocks/MockTokenCreator.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import com.microsoft.identity.labapi.utilities.constants.AzureEnvironment;
import com.microsoft.identity.labapi.utilities.constants.TempUserType;

import org.junit.Ignore;
import org.junit.Test;

import java.util.Arrays;
Expand All @@ -53,6 +54,7 @@
// https://identitydivision.visualstudio.com/DefaultCollection/DevEx/_workitems/edit/497038
@RetryOnFailure(retryCount = 2)
@RunOnAPI29Minus("Speed Bump")
@Ignore("This test relies on ui element on Outlook's mobile website's front page. It's constantly breaking as their ui changes.")
public class TestCase497038 extends AbstractMsalUiTest {

@Test
Expand Down

0 comments on commit ba66d74

Please sign in to comment.