Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automation test issue #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix automation test issue #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_check_webapp_dotnet_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ jobs:
npm install
npm run build

- name: Azure authentication
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_WEBAPP_SPN }}
# - name: Azure authentication
# uses: azure/login@v1
# with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally SPN is the preferred mechanism for auth, any reason to move to publish profile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss this offline.

# creds: ${{ secrets.AZURE_WEBAPP_SPN }}

- name: 'Deploy to Azure WebApp'
uses: ./webapps-deploy/
with:
app-name: ${{ env.AZURE_WEBAPP_NAME }} # Replace with your app name
#publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }} # Define secret variable in repository settings as per action documentation
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }} # Define secret variable in repository settings as per action documentation
package: 'D:\a\webapps-deploy\webapps-deploy\dotnetsample\SampleWebApplication\'
8 changes: 4 additions & 4 deletions .github/workflows/pr_check_windows_container_pubprofile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ jobs:
ref: main
path: 'python_container_App'

- name: Azure authentication
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_WEBAPP_SPN }}
# - name: Azure authentication
# uses: azure/login@v1
# with:
# creds: ${{ secrets.AZURE_WEBAPP_SPN }}

- name: Logout from Azure Container Registry
run: |
Expand Down
Loading