forked from KindDragon/vld
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for unreported memory leaks with Win32 applications #16
Open
avadae
wants to merge
156
commits into
Azure:master
Choose a base branch
from
avadae:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted in x86 builds. Converted projects to vs2022
# Conflicts: # setup/version.h # src/utility.cpp # src/vld.cpp
@avadae, @mattdurak: Any progress on it? |
Add latest two changes
Added innosetup build
No matrix, just build two targets
Added gitversion to determine the version number to be build in the installer
This merge request can be closed - I'll run my own version. It is indeed affecting performance but I do need the x86 version to work. |
Execute gitversion
Fixed path
…icy for all test projects
… small change to vld.cpp inspired by https://github.com/Azure/vld/pull/29/files
- cleaned up the tests - re-implemented the critical section class, making it usable with std::scoped_lock - improved usage with cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reverted a change in utility.cpp that caused memory leaks not to be reported in x86 builds.
A simple leak like this:
was not reported, now it is again.
In the meantime I also updated to vs2022