Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unreported memory leaks with Win32 applications #16

Open
wants to merge 156 commits into
base: master
Choose a base branch
from

Conversation

avadae
Copy link

@avadae avadae commented Mar 9, 2022

I've reverted a change in utility.cpp that caused memory leaks not to be reported in x86 builds.

A simple leak like this:

int main()
{
	int* x = new int {10};
}

was not reported, now it is again.
In the meantime I also updated to vs2022

…orted in x86 builds. Converted projects to vs2022
@ghost
Copy link

ghost commented Mar 9, 2022

CLA assistant check
All CLA requirements met.

@Neustradamus
Copy link

@avadae, @mattdurak: Any progress on it?

@mattdurak
Copy link

//}

VirtualQuery was too slow, QueryVirtualMemoryInformation addressed performance issues.

We are not supporting x86 so any fix here cannot degrade the perf for x64.


Refers to: src/utility.cpp:1298 in 3e46ec8. [](commit_id = 3e46ec8, deletion_comment = False)

@grrava
Copy link

grrava commented Nov 19, 2024

This merge request can be closed - I'll run my own version. It is indeed affecting performance but I do need the x86 version to work.

grrava and others added 30 commits December 22, 2024 19:50
- cleaned up the tests
- re-implemented the critical section class, making it usable with std::scoped_lock
- improved usage with cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants