Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if parameter is a string not an object #362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Check if parameter is a string not an object #362

wants to merge 2 commits into from

Conversation

tonybaloney
Copy link

Fixes #361

@tonybaloney tonybaloney requested a review from a team as a code owner May 3, 2024 02:17
@reynoldsa reynoldsa self-assigned this May 7, 2024
reynoldsa
reynoldsa requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@reynoldsa reynoldsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to cover this case, in ArmTemplateProcessorTests?

JohnathonMohr
JohnathonMohr requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@JohnathonMohr JohnathonMohr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment in the linked issue. I do not understand what this change is trying to accomplish, given the example JSON doesn't appear to comply with the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reynoldsa reynoldsa reynoldsa requested changes

@JohnathonMohr JohnathonMohr JohnathonMohr requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@reynoldsa reynoldsa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fails to pass some templates when evaluating parameters
3 participants
@tonybaloney @reynoldsa @JohnathonMohr