.NET 7, bicep update, and partial parameters #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotpaul
reviewed
Oct 19, 2023
dotpaul
reviewed
Oct 19, 2023
src/Analyzer.TemplateProcessor.UnitTests/ArmTemplateProcessorTests.cs
Outdated
Show resolved
Hide resolved
dotpaul
reviewed
Oct 19, 2023
nonik0
changed the title
JohnathonMohr
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
In the past, getting the PowerShell environment to package correctly in the generated nupkg was complicated. There might be hidden breaking changes going from net6 to net7. Make sure to do lots of testing with PSRule execution specifically on the NuGet package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates target to .net 7 and bicep dependency update with refactoring for use of DI for simplicity
Fixes an issue where a template fails to analyze when providing a parameters file with an incomplete set of parameters. Missing parameter values will now be generated.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines