-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Workload Identity #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
infrastructure
This includes infrastructure changes.
software
This includes software changes.
labels
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 47 out of 62 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- bicep/main.bicep: Language not supported
- bicep/main.parameters.json: Language not supported
- bicep/modules/blade_cluster.bicep: Language not supported
- bicep/modules/blade_configuration.bicep: Language not supported
- bicep/modules/blade_partition.bicep: Language not supported
- bicep/modules/keyvault_secrets.bicep: Language not supported
- bicep/modules/managed-cluster/agent-pool/main.bicep: Language not supported
- bicep/modules/managed-cluster/aks_appconfig_extension.bicep: Language not supported
- bicep/modules/managed-cluster/aks_policy.bicep: Language not supported
- bicep/modules/managed-cluster/main.bicep: Language not supported
- bicep/modules/managed-cluster/maintenance-configurations/main.bicep: Language not supported
- charts/osdu-developer-base/Chart.yaml: Evaluated as low risk
- charts/osdu-developer-init/Chart.yaml: Evaluated as low risk
- charts/blob-upload/Chart.yaml: Evaluated as low risk
- .github/workflows/test.yml: Evaluated as low risk
Comments suppressed due to low confidence (3)
charts/osdu-developer-base/templates/envoy-filter.yaml:63
- The 'appid' claim is used as a fallback for 'x-user-id', which might not be appropriate. 'appid' typically represents application IDs, not user IDs.
request_handle:headers():add("x-user-id", payload["appid"])
charts/osdu-developer-init/README.md:27
- [nitpick] The new namespace 'osdu-core-osdu-init-user' should be verified to ensure it is correct.
helm template osdu-core-osdu-init-user -f custom_values.yaml .
charts/osdu-developer-init/README.md:29
- [nitpick] The new namespace 'osdu-core-osdu-init-partition' should be verified to ensure it is correct.
helm upgrade --install osdu-core-osdu-init-partition . -n $NAMESPACE -f custom_values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
infrastructure
This includes infrastructure changes.
software
This includes software changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set moves the solution to fully leverage workload identity.