Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up local testing by priming Kind cluster's docker registry with all required images #340

Closed
wants to merge 8 commits into from
Closed

Speed up local testing by priming Kind cluster's docker registry with all required images #340

wants to merge 8 commits into from

Conversation

mahalrs
Copy link
Contributor

@mahalrs mahalrs commented Jun 20, 2021

Part of #225

Few changes to local dev workflow:

  • make setup: Create kind cluster with local registry and prepopulate the local registry with required images. Also, load required images to kind node. You need to use this only once or after you run make clean or restart docker/kind.

  • make dev: Deploy the Orkestra helm chart (values-ci.yaml) with Orkestra controller disabled.

  • make debug: Deploy the Orkestra helm chart (values-ci.yaml) with Orkestra controller enabled (in debug mode).

  • make clean-chart: Cleanup any previous Orkestra helm chart installation. When you make any code changes, run make clean-chart && make dev.

  • make clean: Cleanup any Orkestra installation and the kind cluster with registry. After running this target, you must run make setup before running make dev or make debug.

@mahalrs mahalrs changed the title [WIP] Speed up local testing by priming Kind cluster's docker registry with all required images Speed up local testing by priming Kind cluster's docker registry with all required images Jun 23, 2021
@mahalrs mahalrs marked this pull request as ready for review June 23, 2021 19:59
@mahalrs mahalrs requested a review from jonathan-innis as a code owner June 23, 2021 19:59
@mahalrs mahalrs requested a review from nitishm June 25, 2021 19:38
@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 26, 2021

@nitishm Let's merge this, and I will keep an eye on kind PR.

Makefile Show resolved Hide resolved
hack/create-kind-with-registry.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jonathan-innis
Copy link
Contributor

Overall, looks good @mahalrs

@mahalrs mahalrs requested a review from jonathan-innis June 26, 2021 22:36
@nitishm
Copy link
Contributor

nitishm commented Jun 26, 2021

Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?

@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 26, 2021

Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?

It's working locally.

@nitishm
Copy link
Contributor

nitishm commented Jun 27, 2021

Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue

@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 27, 2021

Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it gonna take some time until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

@nitishm
Copy link
Contributor

nitishm commented Jun 27, 2021

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

#343 is a WIP. Are you suggesting we are ready to merge it in? I have left a comment in that PR since it doesn't seem to show significant improvement compared to the original. If you think the changes made there will fix this maybe cherry-pick the changes into this one?

@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 27, 2021

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

#343 is a WIP. Are you suggesting we are ready to merge it in? I have left a comment in that PR since it doesn't seem to show significant improvement compared to the original. If you think the changes made there will fix this maybe cherry-pick the changes into this one?

Yes, that PR is ready to merge in if we run tests sequentially (I did some refactoring to make it easy to track issue with parallel tests). It's just like the code in main branch but refactored. I haven't pushed any other changes in it yet.

EDIT: We will change that PR to a code refactor PR since it doesn't have any changes related to parallel tests.

@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 27, 2021

@nitishm Let me change that PR to a code refactor PR.

@nitishm nitishm mentioned this pull request Jun 27, 2021
@mahalrs mahalrs closed this by deleting the head repository Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants