Incorporating review comments on unnecessary promise handling

Azure · Aug 10, 2017 · fe3b648 · fe3b648
1 parent 9ee65bd
commit fe3b648
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## 0.1.7
 Released on 2017-08-10.
-- Chaining the promises upto `compare` method and gracefully existing application [#88](https://github.com/Azure/openapi-diff/issues/88)
+- Chaining the promises upto `compare` method and gracefully exiting application [#88](https://github.com/Azure/openapi-diff/issues/88)
 
 ## 0.1.x
 Released on 2017-07-18. All issues associated with this release can be found using this filter [Sprint-103](https://github.com/Azure/openapi-diff/issues?q=label%3ASprint-103+is%3Aclosed) [Sprint-104](https://github.com/Azure/openapi-diff/issues?utf8=%E2%9C%93&q=label%3ASprint-104%20is%3Aclosed)

diff --git a/lib/validators/openApiDiff.js b/lib/validators/openApiDiff.js
@@ -60,9 +60,7 @@ class OpenApiDiff {
     var promise2 = self.processViaAutoRest(newSwagger, 'new');
 
     return Promise.all([promise1, promise2]).then(results => {
-      return self.processViaOpenApiDiff(results[0], results[1]).then((result, error) => {
-        return Promise.resolve(result);
-      });
+      return self.processViaOpenApiDiff(results[0], results[1]);
     });
   }