-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private IPs and Docker in SpaceStation #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting a PR! 🙌
I left some feedback in this review, but I was never able to get a .devcontainer build to run successfully and kept getting a updateContentCommand
error from VS Code:
The updateContentCommand in the devcontainer.json failed.
I have the full log if you'd like to pair up offline, but here's the offending error:
[2021-10-01T15:39:40.053Z] Command failed: /bin/sh -c /tmp/library-scripts/mock-spacestation-setup.sh
EDIT: found the issue, looks like permissions:
[2021-10-01T15:39:39.918Z] /bin/sh: 1: /tmp/library-scripts/mock-spacestation-setup.sh: Permission denied
chmod'ing the library-scripts
directory fixed that issue:
chmod -R 755 .devcontainer/library-scripts
Should be able update the permissions on the scripts on that directory and push them back up 👍
…spacestation-setup.sh
update permissions for scripts and use sudo chown in mock-spacestation-setup.sh
@glennmusa updates made; successful test on Win10. Good to go on this side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ground station and space station sync is working on both the Azure deployed VM and in the local .devcontainer from Ubuntu 20.04! Woot! 🚀
I'll add some tasks to the backlog to update docs and address shellcheck warnings, but thank you very much @bigtallcampbell!
Description
Issue reference
#28 @cbrown101