Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private IPs and Docker in SpaceStation #29

Merged
merged 29 commits into from
Oct 2, 2021
Merged

Private IPs and Docker in SpaceStation #29

merged 29 commits into from
Oct 2, 2021

Conversation

bigtallcampbell
Copy link
Contributor

Description

  • Updated to use private network
  • Consolidated to a single VM / dev container
  • Mock Space Station is now a container with docker installed
  • Private network between Mock Ground Station and Mock Space Station is bandwidth constrained to match ISS
  • Applied latest production configuration to Space Station image
  • Miscellaneous notes update

Issue reference

#28 @cbrown101

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! 🙌

I left some feedback in this review, but I was never able to get a .devcontainer build to run successfully and kept getting a updateContentCommand error from VS Code:

The updateContentCommand in the devcontainer.json failed.

I have the full log if you'd like to pair up offline, but here's the offending error:

[2021-10-01T15:39:40.053Z] Command failed: /bin/sh -c /tmp/library-scripts/mock-spacestation-setup.sh

EDIT: found the issue, looks like permissions:

[2021-10-01T15:39:39.918Z] /bin/sh: 1: /tmp/library-scripts/mock-spacestation-setup.sh: Permission denied

chmod'ing the library-scripts directory fixed that issue:

chmod -R 755 .devcontainer/library-scripts

Should be able update the permissions on the scripts on that directory and push them back up 👍

AzureVM.bicep Outdated Show resolved Hide resolved
AzureVM.bicep Outdated Show resolved Hide resolved
AzureVM.bicep Outdated Show resolved Hide resolved
Convert-AzureVMsetup.ps1 Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
ssh-to-spacestation.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bigtallcampbell
Copy link
Contributor Author

@glennmusa updates made; successful test on Win10. Good to go on this side.

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ground station and space station sync is working on both the Azure deployed VM and in the local .devcontainer from Ubuntu 20.04! Woot! 🚀

I'll add some tasks to the backlog to update docs and address shellcheck warnings, but thank you very much @bigtallcampbell!

@glennmusa glennmusa merged commit d6356b9 into Azure:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants