Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: add --clients and --content-type flags to runner command #16

Closed
wants to merge 2 commits into from
Closed

cmd: add --clients and --content-type flags to runner command #16

wants to merge 2 commits into from

Conversation

PugDeveloper
Copy link

Add code to facilitate:

  • when client num is > conns num, reuse existing connection
  • accept protobuf as content type

@PugDeveloper PugDeveloper requested a review from fuweid January 3, 2024 03:54
fuweid
fuweid reviewed Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That second commit seems unrelated change. Please remove that second commit.

.gitignore Outdated Show resolved Hide resolved
request/client.go Outdated Show resolved Hide resolved
request/client.go Outdated Show resolved Hide resolved
request/client.go Outdated Show resolved Hide resolved
request/schedule.go Show resolved Hide resolved
request/schedule.go Show resolved Hide resolved
request/schedule.go Outdated Show resolved Hide resolved
request/schedule.go Show resolved Hide resolved
request/client.go Show resolved Hide resolved
@fuweid fuweid changed the title Update code to improve connection handling and support for protobuf as content type cmd: add --clients and --content-type flags to runner command Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PugDeveloper @fuweid