Merge pull request #8 from fuweid/weifu/fix-runner-option

runner: use default value if flag is not set
Azure · Dec 21, 2023 · 2c93ca6 · 2c93ca6
2 parents a57838b + c6080af
commit 2c93ca6
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/cmd/kperf/commands/runner/runner.go b/cmd/kperf/commands/runner/runner.go
@@ -95,11 +95,15 @@ func loadConfig(cliCtx *cli.Context) (*types.LoadProfile, error) {
 	}
 
 	// override value by flags
-	//
-	// TODO(weifu): do not override if flag is not set
-	profileCfg.Spec.Rate = cliCtx.Int("rate")
-	profileCfg.Spec.Conns = cliCtx.Int("conns")
-	profileCfg.Spec.Total = cliCtx.Int("total")
+	if v := "rate"; cliCtx.IsSet(v) {
+		profileCfg.Spec.Rate = cliCtx.Int(v)
+	}
+	if v := "conns"; cliCtx.IsSet(v) || profileCfg.Spec.Conns == 0 {
+		profileCfg.Spec.Conns = cliCtx.Int(v)
+	}
+	if v := "total"; cliCtx.IsSet(v) || profileCfg.Spec.Total == 0 {
+		profileCfg.Spec.Total = cliCtx.Int(v)
+	}
 
 	if err := profileCfg.Validate(); err != nil {
 		return nil, err