-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add allowedPropagatingAPIs option for resource selection #638
Merged
zhiying-lin
merged 12 commits into
Azure:main
from
vasudev-bongale:vasudev-bongale/allowed-apis
Dec 21, 2023
Merged
feat: add allowedPropagatingAPIs option for resource selection #638
zhiying-lin
merged 12 commits into
Azure:main
from
vasudev-bongale:vasudev-bongale/allowed-apis
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9958a07
to
82ae57c
Compare
zhiying-lin
reviewed
Dec 15, 2023
pkg/controllers/clusterresourceplacement/placement_controllerv1alpha1.go
Outdated
Show resolved
Hide resolved
zhiying-lin
reviewed
Dec 19, 2023
zhiying-lin
reviewed
Dec 20, 2023
zhiying-lin
reviewed
Dec 21, 2023
pkg/controllers/clusterresourceplacement/placement_controllerv1alpha1.go
Outdated
Show resolved
Hide resolved
zhiying-lin
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--allowed-propagating-apis
option to hub-agent command.--allowed-propagating-apis
and--skipped-propagating-apis
are mutually exclusive and cannot be specified together.DisabledResourceConfig
type into a genericResourceConfig
so that we can reuse it for bothAllowed
andDisabled
resource configs. During initializingDisabledResourceConfig
, fleet and built-in resources are configured.change_detector
to watch only the allowed resources if specified.resource_selector
to only select allowed resources if specified.Other changes
help
recipe for developers to list the available commands in the Makefile.Fixes #633
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Verify that the options are mutually exclusive.
Run hub-agent locally, its able to start with the right option value for
--allowed-propagating-apis
Verify that the Allowed resources are being watched and informer is created
It selects the correct resources
$ make help