Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: LoadTest Setup #630

Merged
merged 11 commits into from
Dec 14, 2023
Merged

test: LoadTest Setup #630

merged 11 commits into from
Dec 14, 2023

Conversation

britaniar
Copy link
Contributor

@britaniar britaniar commented Dec 1, 2023 •
edited
Loading

Description of your changes

https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/personalplayground/622677/Performance-Load-Test
Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@britaniar britaniar changed the title testing: LoadTest Setup for PickFixed tests: LoadTest Setup for PickFixed Dec 1, 2023
@britaniar britaniar changed the title tests: LoadTest Setup for PickFixed test: LoadTest Setup for PickFixed Dec 1, 2023
@britaniar
Copy link
Contributor Author

Current test reads in a crp yaml file and creates a crp with the spec from the file. The crps applied are all the same spec wise.
Would it be best to have fixed crps of different policies or continue reading yaml file? Based on the answer to the question, I have a way in mind to implement different crps with different policies in one load test.

@britaniar britaniar marked this pull request as ready for review December 8, 2023 19:53
@britaniar britaniar changed the title test: LoadTest Setup for PickFixed test: LoadTest Setup Dec 8, 2023
@britaniar britaniar requested a review from michaelawyu December 8, 2023 19:53
michaelawyu
michaelawyu reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, PTAL.

hack/loadtest/util/help.go Outdated Show resolved Hide resolved
hack/loadtest/util/placement.go Outdated Show resolved Hide resolved
hack/loadtest/util/placement.go Outdated Show resolved Hide resolved
hack/loadtest/util/placement.go Outdated Show resolved Hide resolved
hack/loadtest/util/placement.go Show resolved Hide resolved
hack/loadtest/util/placement.go Outdated Show resolved Hide resolved
hack/loadtest/util/placement.go Show resolved Hide resolved
hack/loadtest/util/placement.go Outdated Show resolved Hide resolved
hack/loadtest/test-crp.yaml Show resolved Hide resolved
michaelawyu
michaelawyu approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock the progress; some changes will be addressed in a separate PR.

@britaniar britaniar merged commit 321ebd3 into Azure:main Dec 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arvindthiru Arvindthiru Arvindthiru left review comments

@michaelawyu michaelawyu michaelawyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@britaniar @michaelawyu @Arvindthiru