-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set the default ttl to 60s #235
Conversation
109b5eb
to
9e9f6a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 79.76% 79.96% +0.20%
==========================================
Files 27 27
Lines 3840 3844 +4
==========================================
+ Hits 3063 3074 +11
+ Misses 621 615 -6
+ Partials 156 155 -1 ☔ View full report in Codecov by Sentry. |
8d7c81b
to
3b543fa
Compare
3b543fa
to
2eb1cc0
Compare
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- go.mod: Language not supported
- pkg/controllers/hub/trafficmanagerprofile/controller_test.go: Evaluated as low risk
- test/common/trafficmanager/validator/profile.go: Evaluated as low risk
- test/common/trafficmanager/fakeprovider/profile.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
test/e2e/e2e_test.go:96
- [nitpick] The error message 'Failed to create client' is vague. It should be updated to specify which client creation failed, e.g., 'Failed to create ProfilesClient' or 'Failed to create EndpointsClient'.
Expect(err).Should(Succeed(), "Failed to create client")
5244e8b
to
b920825
Compare
What type of PR is this?
/kind bug
/kind test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewable
for basic local testHow has this code been tested
e2e tests passed, https://github.com/Azure/fleet-networking/actions/runs/12463049682
Special notes for your reviewer