Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the default ttl to 60s #235

Merged
merged 5 commits into from
Dec 24, 2024
Merged

fix: set the default ttl to 60s #235

merged 5 commits into from
Dec 24, 2024

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Dec 23, 2024

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:

  • fix the TTL bug, atm's ttl default value is 0
  • add azure client in e2e to validate azure resources

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

e2e tests passed, https://github.com/Azure/fleet-networking/actions/runs/12463049682

Special notes for your reviewer

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (a3d3bd7) to head (b920825).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   79.76%   79.96%   +0.20%     
==========================================
  Files          27       27              
  Lines        3840     3844       +4     
==========================================
+ Hits         3063     3074      +11     
+ Misses        621      615       -6     
+ Partials      156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • go.mod: Language not supported
  • pkg/controllers/hub/trafficmanagerprofile/controller_test.go: Evaluated as low risk
  • test/common/trafficmanager/validator/profile.go: Evaluated as low risk
  • test/common/trafficmanager/fakeprovider/profile.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/e2e/e2e_test.go:96

  • [nitpick] The error message 'Failed to create client' is vague. It should be updated to specify which client creation failed, e.g., 'Failed to create ProfilesClient' or 'Failed to create EndpointsClient'.
Expect(err).Should(Succeed(), "Failed to create client")

@zhiying-lin zhiying-lin merged commit 153b55b into main Dec 24, 2024
10 checks passed
@zhiying-lin zhiying-lin deleted the set-e2e-env branch December 24, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants