fix: fix the atm feature related bugs #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
force-pushed
the
fix-bugs
branch
from
37dc870 to
aa15e4a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 79.68% 79.76% +0.08%
==========================================
Files 27 27
Lines 3819 3820 +1
==========================================
+ Hits 3043 3047 +4
+ Misses 620 618 -2
+ Partials 156 155 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jwtty
reviewed
Nov 19, 2024
jwtty
approved these changes
Nov 20, 2024
jamyct
pushed a commit
to jamyct/fleet-networking
that referenced
this pull request
Dec 3, 2024
jamyct
added a commit
that referenced
this pull request
Jan 4, 2025
* add kubebuilders validations for name length to be <= 63 * add validation tests for member cluster service * delete e2e test file * add tests for service export * add service import tests * add tests for service import and traffic manager profile/backend * add integration test to makefile * set TimeoutInSeconds default to 9 * add conditions for MonitorConfig * add message to rule * add second values to monitorconfig * run goimports * resolve type comparison issue in CEL * add case fo when intervalInSeconds is not 30 or 10 * when IntervalInSeconds is 10, TimeoutInSeconds should be between 5 & 9 * add integration-test to test * test all integration potential files * remove additional conditions * remove role.yaml changes * fix filepath in hubtestenv * add copyright banner, fix format and change wording * fix: fix the atm feature related bugs (#220) * docs: add application migration tutorials (#222) doc * fix: requeue the request when the dns is not assigned (#225) fix: requeue the request when the dns is not assigned * chore: bump thehanimo/pr-title-checker from 1.4.2 to 1.4.3 (#224) Bumps [thehanimo/pr-title-checker](https://github.com/thehanimo/pr-title-checker) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/thehanimo/pr-title-checker/releases) - [Commits](thehanimo/pr-title-checker@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: thehanimo/pr-title-checker dependency-type: direct:production update-type: version-update:semver-patch ... * rebase * fix conflict * edit role.yaml * delete e2e resource validation test * add namespace in suit_test.go * add namespace in suit_test.go * fix directory for integration test * update integration tests to use names longer than 63 * make names valid * fix error message substring check for invalid RFC 1123 names * fix naming to multiClusterServiceName * remove example test files * copyright banner * remove integration coverage xml file * fix import format in suite_test.go * edit format * undo edit * delete print error and add error message if namespace not created * rename fleetnetv1alpha1 for better readability * use global variable for namespace string * delete namespace in aftersuite * use ginkgo to run integration test * fix context * fix names of strings to test * create global variable for nameWithInvalidSize * install ginkgo * create global name variables within integration test file * create global name variables for all remaining name types * fix hubclient creation failure message and add deletiong failure message * add hub client creation and deletion messages in integration test file * install ginkgoin .github/workflows/unit-integration-tests.yml * fix import styling in integration test file * undo cluster to name change * fix cluster access issue * fix member variable issue in traffic manager test * install ginkgo before running tests * remove unnecessary extra lines * declare var statusErr once and remove duplicate declarations * declare reused specs once and remove duplication * declare reused objectmeta once and remove duplications + correct alphabet spelling * resolve conflict with lates commit --------- Co-authored-by: Zhiying Lin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
manual test, will add the e2e tests in the future PR.
Special notes for your reviewer