Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log current backoff in WaitingForMoreMessages #1064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidmrdavid
Copy link
Collaborator

In some recent performance-sensitive investigations, I've found it challenging not to have access to the current queue-polling backOff whenever a WaitingForMoreMessages delay takes place. I think it would be nice to include this in our logs, so that we're armed with precise data on how much latency is expected between MessageReceived operations (assuming the queue is populated).

@davidmrdavid davidmrdavid marked this pull request as ready for review April 16, 2024 05:29
@cgillum
Copy link
Member

cgillum commented Apr 16, 2024

I think there's a slight misunderstanding here. We only log WaitingForMoreMessages once until more messages arrive. We don't log it repeatedly, which I think this PR assumes. Otherwise, we'd be spamming the logs with polling messages when the app is idle, which we don't want to do for informational messages.

If you want to monitor the polling delay, then I suggest introducing a new debug-level log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants