Add Automatic suffix generation for DTFx.Core and DTFx.AzureStorage #1025
Conversation
davidmrdavid
changed the title
|
|
||
| <!-- This version is used as the nuget package version --> | ||
| <PropertyGroup Condition="$(VersionSuffix) == ''"> | ||
| <Version>$(MajorVersion).$(MinorVersion).$(PatchVersion)</Version> |
There was a problem hiding this comment.
Should we continue to use $(VersionPrefix) like we were before, or did you have a reason to remove it?
There was a problem hiding this comment.
I've re-added it. I can't recall exactly why I removed it (a local version of this PR has been sitting on my devbox for a while).
azure-pipelines-release.yml
Outdated
| pr: none | ||
|
|
||
| pool: | ||
| name: '1ES-Hosted-DurableTaskFramework' | ||
| demands: | ||
| - ImageOverride -equals MMS2022TLS | ||
|
|
||
| variables: | ||
|
|
||
| - name: PackageSuffix |
There was a problem hiding this comment.
It seems PackageSuffix serves the same purpose as VersionSuffix. Was there a reason not to simply assign VersionSuffix directly as an alternative to creating a new build variable?
There was a problem hiding this comment.
I've unified them in VersionSuffix. I think I had made them differently because I wasn't sure to what extend I could just continue reading env variables in the .csproj. So far, it seems like I can do that with no restrictions, so I've removed the VersionSuffix xml variable I introduced and replaced it with this env var.
|
@cgillum: could you give this another pass? |
As in title: automation to generate preview packages of DTFx.Core and DTFx.AzureStorage on ADO. This is the DTFX equivalent of: Azure/azure-functions-durable-extension#2709
This PR does two things:
(1) It makes the pipeline run automatically after every commit to the
mainbranch(2) On any automatic run, it appends a suffix to the generated package version.
In the long run, we can take this package version and automatically push it to our ADO feed so that it may be consumed by our pre-existing nightly DF Extension testing feed, so that we have nightly testing coverage across repos.