Fixing indentation in the generated configuration

[Aniruddh25]

Why make this change?

• With the overhaul of the config system using our own Write method while serializing objects, the config that is generated is misaligned with respect to indentation for all the keys under each entity name.
  For e.g.:
  In the following picture, the entity name Todo is indented with 4 leading spaces, subsequently its child key source should have been indented with 6 leading spaces, however its currently indented with only 2 spaces.

• This is a regression in 0.8.44-rc - introduced in Overhaul of config system #1402

What is this change?

• Use the same writer to serialize the subkeys under the entity name so that the depth of indentation is maintained.

How does this change fix the issue?

• WriteRawValue writes the json string argument provided as is without doing any additional formatting on it. It doesn't utilize the _currentDepth private member of the writer to determine how to indent.

• Prior to this change, we were generating the inner json string first then writing the generated inner json "as is". While generating that json on line 29

data-api-builder/src/Config/Converters/RuntimeEntitiesConverter.cs

Line 29 in 31b7542

string json = JsonSerializer.Serialize(entity, options);

Line 29 in 31b7542

a new writer is being used by the JsonSerializer.Serialize() function, effectively resetting the _currentDepth. The _currentDepth of the writer in context was not getting honored.

How was this tested?

• Manual test, building solution and using dab add to simulate automatic writing of an entity to the config file. With the change, the indentation is fixed.

[aaronpowell]

Should we regenerate the config files in the test projects to make sure they are formatted properly (or are they already?)

[severussundar]

Thank you for spotting and fixing this!