fix: test2json: detect test timeouts and other package-level errors #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This was ignoring all non-test events, unfortunately this means if there is a panic or a test timeout we may not detect the failure. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_timeouts
branch
from
ef58c7f to
fcf1720
Compare
|
Looking into what's taking the packages so long. |
|
Superseded by #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was ignoring all non-test events, unfortunately this means if there is a panic or a test timeout we may not detect the failure.
Fixes #476