Source Refactor #117
Merged
Source Refactor #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
commented
Feb 9, 2024
adamperlin
force-pushed
the
adamperlin/source-refactor
branch
from
4e5c819 to
96061f5
Compare
Closed
adamperlin
force-pushed
the
adamperlin/source-refactor
branch
from
9b83cd0 to
d600d45
Compare
cpuguy83
requested changes
Feb 14, 2024
cpuguy83
requested changes
Feb 26, 2024
source.go
Outdated
| return src.DockerImage != nil && src.DockerImage.Cmd != nil | ||
| } | ||
|
|
||
| func GetFilter(src Source, forMount bool, opts ...llb.ConstraintsOpt) llb.StateOption { |
There was a problem hiding this comment.
This should be uneported, and maybe inlined in GetSource?
There was a problem hiding this comment.
I'd rather not inline it to avoid passing forMount through getSource, if that's ok
…ssing into nested build
cpuguy83
approved these changes
Feb 27, 2024
|
This says there's conflicts. |
|
It doesn't state the conflicts which is super weird. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the source generation code in
sources.go.In particular:Note: This could probably wait for #110, as those unit tests would probably be better able to catch any bugs in the filter handling logic introduced here.