Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Integration tests possible not reporting failures #476

Open
1 task
DannyBrito opened this issue Dec 12, 2024 · 2 comments · May be fixed by #421
Open
1 task

[BUG] Integration tests possible not reporting failures #476

DannyBrito opened this issue Dec 12, 2024 · 2 comments · May be fixed by #421
Labels
bug Something isn't working

Comments

@DannyBrito
Copy link
Contributor

DannyBrito commented Dec 12, 2024 •
edited
Loading

Expected Behavior

https://github.com/Azure/dalec/actions/runs/12283069321/job/34275695113?pr=472#step:9:158,
It seems that the test is timeout or not really sure the cause but there is a panic and CI is not failing.
Not sure if that is expected?

Actual Behavior

I would expect the integration tests to mark CI as failure

Steps To Reproduce

No response

Are you willing to submit PRs to contribute to this bug fix?

  • Yes, I am willing to implement it.
@DannyBrito DannyBrito added the bug Something isn't working label Dec 12, 2024
@cpuguy83
Copy link
Member

Oh my.

@cpuguy83 cpuguy83 mentioned this issue Dec 20, 2024
Closed
@cpuguy83
Copy link
Member

#482 should take care of this.
Nice find.

@cpuguy83 cpuguy83 linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@cpuguy83 @DannyBrito