Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved issue where toolbar wasn't focused when show editing options #5611

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Resolved issue where toolbar wasn't focused when show editing options #5611

wants to merge 8 commits into from
+14 −7

Conversation

palatter
Copy link
Member

@palatter palatter commented Feb 3, 2025

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@palatter palatter requested review from a team as code owners February 3, 2025 19:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qqakuwuagk.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56997 / 93990
60.64%		 56997 / 93990
60.64%		 1161 / 2687
43.2%		 3480 / 5742
60.6%
Current 56951 / 93991
60.59%		 56951 / 93991
60.59%		 1160 / 2686
43.18%		 3445 / 5713
60.3%
Diff -46 / 1
-0.05%		 -46 / 1
-0.05%		 -1 / -1
-0.02%		 -35 / -29
-0.3%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27881 / 44338
62.88%		 27881 / 44338
62.88%		 782 / 1423
54.95%		 2345 / 3712
63.17%
Current 27879 / 44338
62.87%		 27879 / 44338
62.87%		 781 / 1422
54.92%		 2320 / 3694
62.8%
Diff -2 / 0
-0.01%		 -2 / 0
-0.01%		 -1 / -1
-0.03%		 -25 / -18
-0.37%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mybxpjktkn.chromatic.com/

@palatter palatter force-pushed the palatter/fix-focus-editing-options branch from ac213ee to 34ff1cb Compare February 3, 2025 23:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ryibnqnbkn.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ogzqnzjudl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kjqujhrike.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Chat bundle size is not changed.

  • Current size: 1777206
  • Base size: 1777206
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mpduswfdsy.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palatter @JoshuaLai @vhuseinova-msft