Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix bug where adapter captions event is not firing " #5090

Closed
wants to merge 1 commit into from
Closed

Revert "Fix bug where adapter captions event is not firing " #5090

wants to merge 1 commit into from

Conversation

carocao-msft
Copy link
Contributor

Reverts #5065

@carocao-msft carocao-msft changed the base branch from main to release/1.19.0-beta.2 August 29, 2024 16:22
@carocao-msft carocao-msft changed the base branch from release/1.19.0-beta.2 to main August 29, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-epvjtnuqoo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 8140159
  • Base size: 8140159
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 8140145
  • Base size: 8140145
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 2109938
  • Base size: 2109938
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rsrujrpdqd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26334 / 42240
62.34%		 26334 / 42240
62.34%		 723 / 1309
55.23%		 2097 / 3342
62.74%
Current 26389 / 42240
62.47%		 26389 / 42240
62.47%		 723 / 1309
55.23%		 2096 / 3349
62.58%
Diff 55 / 0
0.13%		 55 / 0
0.13%		 0 / 0
0%		 -1 / 7
-0.16%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53932 / 88163
61.17%		 53932 / 88163
61.17%		 1078 / 2462
43.78%		 3180 / 5244
60.64%
Current 53934 / 88170
61.17%		 53934 / 88170
61.17%		 1078 / 2462
43.78%		 3161 / 5228
60.46%
Diff 2 / 7
0%		 2 / 7
0%		 0 / 0
0%		 -19 / -16
-0.18%

@carocao-msft carocao-msft deleted the revert-5065-carocao/captionBug branch October 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carocao-msft @JamesBurnside