Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support private module completions #16051

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Jan 9, 2025

Fixes #9038

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford changed the title Support private module completions [WIP] Support private module completions Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test this change out locally with the following install scripts (Action run 13147146891)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13147146891
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13147146891"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13147146891
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13147146891"

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   35m 55s ⏱️ - 15m 53s
11 746 tests +     4  11 746 ✅ +     4  0 💤 ±0  0 ❌ ±0 
27 250 runs   - 13 569  27 250 ✅  - 13 569  0 💤 ±0  0 ❌ ±0 

Results for commit 7bbbb65. ± Comparison against base commit 6f7bd87.

This pull request removes 1849 and adds 682 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Cli.IntegrationTests.UseRecentModuleVersionsIntegrationTests ‑ IfNoRestoreSpecified_ThenShouldNotDownloadMetadata_AndShouldFailBecauseNoCache
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�ӽ\u000e� \u0010\u0007p�>\u0005O�\u001cx�\u000e�\u001d�
�5�G�F45i��šI\u0007M\u0017�M�o`�r��E��������\u0002un\u0012��&\u0003����\u0003@`@/�IB#\u0019��쓌�|k�0�\u0012g� �q۞��\u0000�\u0019�69�L�2�6����\u0001���Xt���\u0013g_����jX��Ѩ����\u0013}ʿ��AJ(Q!h
�\u001fV�\u0017�����X{�(��h
OJ�4!\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Ի
�0\u0014\u0006��>E�\u0003�Is3B\u0007���TAp�`\u0003Vh��B��7\u001dĥť\u0017�|cr '	�A�^�k�\u0013S��S%|\u0004��-�X�z�0	�|�\u0000K.8\u0000�\u0016��҅me��~P0��J3\u0013\u0012I�P�\u0014��
F���;w�\u0011\u0005ﺺ�i��\u001a]�[ޔg]�S_�������[�q���\u0001\u001c�\u0013F\u0001\u0016��<�Q2����zQ|\n��is���\u0002�	<uO��8��^t\u0007u�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K
�0\u0010\u0006�=E�\u0001bҼ\u001a�{7�\u001b\u000f\u0010�\u0011+���BA���Bܴ��C0�23�I�\u001f���v\u000b6��&�\u001b�&hl�QB��w�Ј�7���J"���'�q�\u001b[�Q���\u0007�\u0011�M�C�4�4��\u0018"��"�+WK�j���6�8+Rhɥ�\u0015]{>Ծ�1�\u0001����r��\u001f �\u000c%\u0013\u001cQ%%s��%����\u0007\u000e\u000e\u0005�%$
�;ȏP\u0005\u001b|��\u001a�K��y��M�\u0005x���\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�ӽ
�0\u0010\u0007��>E� ��$M�BЂ\u001f4�6ł����R[���\u001c�]8�"۹~[�CٴBj�L��A�+5�>@�\u000c�\u000b00ZI�x?�&#�6�&��Ĭ\u001fD��p��\u0002��\u0006e\u000eR\u0010\u0010���X�O֐_]8\u0016�����Ź���PM5���d����5�S�\u0001��2\u001a4i\u0000\u0019�db�\u0017�����X{�$I�d
O�Lm�\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0000��>E�\u0003��&i��Ap�"U\u0010\%؀\u0015Z��P��M\u0007qiq�`�1wp\u0017�;��U��*�EI�\u0000�%�o`����7(���7@ �\u0000�p�{'-\u001ee�
��\u0018�~�7ǪJ3\u001dR��2\u001f8	\u0002�8g3\u0013;w�h�諸�i��\�[ޤg]�S�����p5��?x\u001c�\u001b @x\u0002�#�E��G��?���\u0013���6Z�6�]�,���S�dY�e
�\u0005�nÓ\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0007��>E�\u0003�K�K���Ep�\u0001b{�b��\u0011
�\u001b\u0007qiq�\u000b�o�\u001d܅��\u0018/\7#WR�
���\u0005{5\u0008�ֽ�7R[&�\u001d0���\u0018�^�I�S�]\u0013V�Ĭ\u001f�f��mE��*�R\u0019@\u0001��X��B�\u0018��	?:�ɷuI�ص���^
����р���oƳ���,�\u0001\u0008�"\u000020�M��G2���?�dYSw��S9�jEM2�k�o���ݢ(����\u0002�E�?\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Repository_not_found_in_registry (ArtifactRegistryAddress { RegistryAddress = mcr.microsoft.com, RepositoryPath = unknown/path/az, ExtensionVersion = 0.0.0-placeholder, RegistryUri = https://mcr.microsoft.com/ },Azure.RequestFailedException: The artifact does not exist in the registry.,[(BCP192, Error, Unable to restore the artifact with reference "br:mcr.microsoft.com/unknown/path/az:0.0.0-placeholder": The artifact does not exist in the registry.)])
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Repository_not_found_in_registry (ArtifactRegistryAddress { RegistryAddress = unknown.registry.azurecr.io, RepositoryPath = bicep/extensions/az, ExtensionVersion = 0.0.0-placeholder, RegistryUri = https://unknown.registry.azurecr.io/ },System.AggregateException: Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry or by configuring a custom retry policy in ClientOptions.RetryPolicy. (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)),[(BCP192, Error, Unable to restore the artifact with reference "br:unknown.registry.azurecr.io/bicep/extensions/az:0.0.0-placeholder": Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry or by configuring a custom retry policy in ClientOptions.RetryPolicy. (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)))])
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
…

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 5 times, most recently from a447698 to 479ed50 Compare January 16, 2025 00:47
@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 4 times, most recently from af65f40 to 5ea8c28 Compare January 24, 2025 18:56
@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 3 times, most recently from d940471 to 704815e Compare January 31, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ACR (private) module reference completions
1 participant