-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ACR (private) module reference completions #9038
Comments
@StephenWeatherford, let's investigate and document the options here. |
Could you please clarify. Is auto-completion supposed to work for private registries in VSCode or not? It works fine for public registries but doesn't work for private ones. and no It looks like this issue relates to it, but I'm not sure. The issue was renamed (initially it was |
This is definitely something we'd like to do but other priorities have pushed it behind. I'm hoping we can get to it within the next few milestones. |
One other potential enhancement: I noticed if I type a '/' in the registry path, completion is no longer provided (see below) I think it makes sense to make this work similarly to how resource namespace completions work. playground-1728081800057.mp4 |
Yes, that is definitely annoying, the completions were implemented incorrectly here. Someday hopefully I'll get to fixing that. |
@levimatheri I'd actually suggest you create a new bug for this, if one doesn't already exist. It's separate to the private ACR completions. |
Created bug item |
Looking forward for this feature as I'm structuring a global ACR structure for the enterprise and would be great if the development teams could consume it without having to access the Portal to get a list of available modules and their versions. |
Helo. Happy New Year! Do you have any updates on that? Especially in the context of private ACR (AVM). It works fine with public, but not so much with private :(. |
@dariuszbz Thanks! Working on it now. |
For 1st iteration - make sure we include module's description (P1) and link to View documentation (if possible.) |
@dariuszbz @diogocatossi Please try it out, let me know if you run into any issues: #16051 (comment) |
@StephenWeatherford for which version this will be released? Currently Bicep extension is version 0.33.93 from 2025-01-30, 19:36:26, I believe it's in pull request stage so merge didn't happen and I'm not sure we can test it. At the moment it fetches all the ACRs your current context has access to but doesn't goes further to list the repositories, paths and tags like it's done for mcr/avm: |
@diogocatossi Run the appropriate script from the comment I linked to to install the vscode extension version with the changes. Afterwards you can set it back to the 0.33 version (doesn't affect bicep CLI, only vscode extension). |
@StephenWeatherford thank you for the new feature and the extension url. It works great. I was able to see our modules from the private acr. |
Support ACR module reference completions. Part of #3964
Issues:
Implementation:
- 'Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry or by configuring a custom retry policy in ClientOptions.RetryPolicy.
The text was updated successfully, but these errors were encountered: