Add zero to go version (1.22.0) #1415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was not able to compile otherwise on MacOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to compile otherwise on MacOS.
Reason for Change:
I was not able to compile on MacOS:
make
go: downloading go1.22 (darwin/amd64)
go: download go1.22 for darwin/amd64: toolchain not available
go: downloading go1.22 (darwin/amd64)
go: download go1.22 for darwin/amd64: toolchain not available
go: downloading go1.22 (darwin/amd64)
go: download go1.22 for darwin/amd64: toolchain not available
...
After updating go.mod to 1.22.0, this worked without issues.
make
go: downloading go1.22.0 (darwin/amd64)
GOOS=darwin GOARCH=amd64 go build -o /Users/bwiens/dev/git/azure-workload-identity/bin/azwi-darwin-amd64 -ldflags "-X github.com/Azure/azure-workload-identity/pkg/version.BuildTime=$(date +%Y-%m-%d-%H:%M) -X github.com/Azure/azure-workload-identity/pkg/version.BuildVersion=v1.3.0 -X github.com/Azure/azure-workload-identity/pkg/version.Vcs=09f285c -X github.com/Azure/azure-workload-identity/pkg/webhook.ProxyImageVersion=v1.3.0 -X github.com/Azure/azure-workload-identity/pkg/webhook.ProxyImageRegistry=mcr.microsoft.com/oss/azure/workload-identity" ./cmd/azwi
go: downloading monis.app/mlog v0.0.4
go: downloading k8s.io/client-go v0.29.5
...
Also see this reference golang/go#65568 (comment)
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: