Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in comments #3077

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.Azure.WebJobs.Host.Bindings
{
// ValueProvider for binding to an IAsyncCollector.
// TUser is the parameter type from the user function we're binding to.
// TMessage is from the underying IAsyncCollector<TMessage>
// TMessage is from the underlying IAsyncCollector<TMessage>
internal class AsyncCollectorValueProvider<TUser, TMessage> : IOrderedValueBinder
{
private readonly IAsyncCollector<TMessage> _raw;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public IEnumerable<BindingRule> GetRules()
}

// Listed in precedence for providing via DefaultType.
// Precdence is more important than how we produce the default type (a direct conversion vs. a converter)
// Precedence is more important than how we produce the default type (a direct conversion vs. a converter)
private static readonly Type[] _defaultTypes = new Type[] {
typeof(byte[]),
typeof(JObject),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public TextWriter Output
}

// These can be null. They're copied to the old log messages.
// They're magically in sync with where the fuctions write.
// They're magically in sync with where the functions write.

public LocalBlobDescriptor OutputBlob
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Host/HostContainerNames.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Microsoft.Azure.WebJobs.Host
// may point to blobs stored here).
internal static class HostContainerNames
{
// Note that sometimes this container name is used for the Storage account and sometimes for the Dasboard
// Note that sometimes this container name is used for the Storage account and sometimes for the Dashboard
// account. These containers happen to be the same when the accounts are the same.
public const string Hosts = "azure-webjobs-hosts";
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Host/JobHost.cs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ private Task EnsureHostInitializedAsync(CancellationToken cancellationToken)
return _hostInitializationTask;
}

// Caller gaurantees this is single-threaded.
// Caller guarantees this is single-threaded.
// Set initializationTask when complete, many threads can wait on that.
// When complete, the fields should be initialized to allow runtime usage.
private async Task InitializeHostAsync(CancellationToken cancellationToken, TaskCompletionSource<bool> initializationTask)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.Azure.WebJobs.Logging
{
/// <summary>
/// A logger explicitly for writing out logs to the <see cref="TextWriter"/> returned from <see cref="IFunctionOutput.Output"/>. This
/// is only intended to be used with the Function.{FunctionName}.User logger. Most opertions are no-op otherwise.
/// is only intended to be used with the Function.{FunctionName}.User logger. Most operations are no-op otherwise.
/// </summary>
internal class FunctionOutputLogger : ILogger
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Host/PropertyHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ protected static PropertyHelper[] GetVisibleProperties(
// the type to see if we should include it.
var ignoreProperty = false;

// Walk up the hierarchy until we find the type that actally declares this
// Walk up the hierarchy until we find the type that actually declares this
// PropertyInfo.
var currentTypeInfo = type.GetTypeInfo();
var declaringTypeInfo = declaringType.GetTypeInfo();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ internal static int GetCoreAdjustedConcurrency(int concurrency, int otherCores,
// based on number of cores. When running in an App Service plan, all instances will have
// the same VM specs. When running in the Consumption plan, VMs may differ. In the latter case,
// if the snapshot was taken on a VM with a different core count than ours, the adjusted
// concurency we compute may not be optimal, but it's a starting point that we'll dynamically
// concurrency we compute may not be optimal, but it's a starting point that we'll dynamically
// adjust from as needed.
float concurrencyPerCore = (float)concurrency / otherCores;
int adjustedConcurrency = (int)(cores * concurrencyPerCore);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public int MaximumFunctionConcurrency
/// This value is used in conjunction with <see cref="MemoryThreshold"/> to
/// determine when memory based throttling will kick in.
/// A value of -1 indicates that the available memory limit is unknown, and
/// memory based throtting will be disabled.
/// memory based throttling will be disabled.
/// </summary>
/// <remarks>
/// When deployed to App Service, this value will be defaulted based on the SKU
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Microsoft.Azure.WebJobs.Host
{
// $$$ An Inmemory implementation of IDistributedLockManager.
// $$$ An In-memory implementation of IDistributedLockManager.
// Can use this when running on a single node and don't need to coordinate across multiple machines.
internal class InMemoryDistributedLockManager : IDistributedLockManager
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Host/TypeUtility.cs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ internal static TAttribute GetResolvedAttribute<TAttribute>(ParameterInfo parame
var attributeConnectionProvider = attribute as IConnectionProvider;
if (attributeConnectionProvider != null && string.IsNullOrEmpty(attributeConnectionProvider.Connection))
{
// if the attribute doesn't specify an explicit connnection, walk up
// if the attribute doesn't specify an explicit connection, walk up
// the hierarchy looking for an override specified via attribute
var connectionProviderAttribute = attribute.GetType().GetCustomAttribute<ConnectionProviderAttribute>();
if (connectionProviderAttribute?.ProviderType != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class InstanceCountEntity : TableEntity
const string RowKeyPrefix = "{0:D20}-";
const string RowKeyFormat = "{0:D20}-{1}-{2}"; // timestamp ticks, container name, salt

// Have a salt value for writing to avoid collisions since timeBucket is not gauranteed to be unique
// Have a salt value for writing to avoid collisions since timeBucket is not guaranteed to be unique
// when many functions are quickly run within a single time tick.
static int _salt;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ internal static string RowKeyFunctionInstanceId(Guid functionInstanceId)
public DateTime? EndTime { get; set; }

// Last heart beat. When EndTime is missing, this lets us guess if the function is still alive.
// Whereas Start and End are written very determinsitically in the lifecycle,
// Whereas Start and End are written very deterministically in the lifecycle,
// heartbeat is special because it's written at potentially random times by a background poller thread.
public DateTime? FunctionInstanceHeartbeatExpiry { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

namespace Microsoft.Azure.WebJobs.Logging
{
// Index that provides list of recention invocations per function type.
// 1 entity per Intance of a function that's executed.
// Index that provides list of recent invocations per function type.
// 1 entity per Instance of a function that's executed.
internal class RecentPerFuncEntity : TableEntity, IRecentFunctionEntry, IEntityWithEpoch
{
const string PartitionKeyFormat = TableScheme.RecentFuncIndexPK;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/FunctionId.cs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public override bool Equals(object obj)
}

/// <summary>
/// Inquality
/// Inequality
/// </summary>
/// <param name="left"></param>
/// <param name="right"></param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace Microsoft.Azure.WebJobs.Logging
{
/// <summary>
/// Publically visible.
/// Publicly visible.
/// Represent a function invocation.
/// </summary>
public class FunctionInstanceLogItem : IFunctionInstanceBaseEntry
Expand Down Expand Up @@ -47,8 +47,8 @@ public class FunctionInstanceLogItem : IFunctionInstanceBaseEntry
public DateTime? EndTime { get; set; }

/// <summary>A function outputs a heartbeat while it's running.
/// If EndTime = null and heartbeat is "old", then the function is likley abandoned (machine killed).
/// It's always possible a node loses network connectity, and so we appear abandoned, but
/// If EndTime = null and heartbeat is "old", then the function is likely abandoned (machine killed).
/// It's always possible a node loses network connectivity, and so we appear abandoned, but
/// the function successfully completes</summary>
/// <inheritdoc/>
public DateTime? FunctionInstanceHeartbeatExpiry { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public enum FunctionInstanceStatus
Unknown = 0,

/// <summary>
/// Function has been triggered and ready to run, but is blocked on some prerequeisite.
/// Function has been triggered and ready to run, but is blocked on some prerequisite.
/// </summary>
Blocked,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ protected override async Task WriteEntry(long ticks, int currentActive, int tota
/// <summary>
/// Poll, return the ticks.
/// </summary>
/// <param name="token">cancellation token to interupt the poll. Don't throw when cancelled, just return early.</param>
/// <param name="token">cancellation token to interrupt the poll. Don't throw when cancelled, just return early.</param>
/// <returns>Tick counter after the poll.</returns>
protected override async Task<long> WaitOnPoll(CancellationToken token)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public void Decrement(Guid instanceId)
/// <summary>
/// Poll, return the ticks.
/// </summary>
/// <param name="token">cancellation token to interupt the poll.
/// <param name="token">cancellation token to interrupt the poll.
/// Don't throw when cancelled, just return early because we still need a tick counter returned.</param>
/// <returns>Tick counter after the poll. </returns>
protected abstract Task<long> WaitOnPoll(CancellationToken token);
Expand All @@ -100,7 +100,7 @@ public void Decrement(Guid instanceId)
/// <returns></returns>
protected abstract Task WriteEntry(long ticks, int currentActive, int totalThisPeriod);

// Wrap cancellation token and task in a separate class so that StopAsync() doesn't reccyle them.
// Wrap cancellation token and task in a separate class so that StopAsync() doesn't recycle them.
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1001:TypesThatOwnDisposableFieldsShouldBeDisposable")]
class Worker
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/Internal/LogReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ string continuationToken
throw new InvalidOperationException("illegal time range");
}

// Shrink to phsyical.
// Shrink to physical.
var epochs = _tables.Keys.ToArray();
if (epochs.Length == 0)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/Internal/LogWriter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace Microsoft.Azure.WebJobs.Logging
internal class LogWriter : ILogWriter
{
// Logs from AddAsync() are batched up. They can be explicitly flushed via FlushAsync() and
// they get autotmatically flushed at Interval.
// they get automatically flushed at Interval.
// Calling AddAsync() will startup the background flusher. Calling FlushAsync() explicitly will disable it.
private CancellationTokenSource _cancelBackgroundFlusher = null;
private Task _backgroundFlusherTask = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ private static string EscapeStorageCharacter(char character)
// Normalize must be one-to-one to avoid collisions.
// Escape any non-alphanumeric characters so that we
// a) have a valid rowkey name
// b) don't have characeters that conflict with separators in the row key (like '-')
// b) don't have characters that conflict with separators in the row key (like '-')
public static string NormalizeFunctionName(string functionName)
{
StringBuilder sb = new StringBuilder();
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/Internal/TimeBucket.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public static long GetEpochNumberFromTable(CloudTable table)
return -1;
}

// Epoch must be positive, orderd integers.
// Epoch must be positive, ordered integers.
// Use YYYYMM
private static long GetEpochSuffixNumber(DateTime epoch)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/Internal/Utility.cs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public static async Task WriteBatchAsync<T>(this ILogTableProvider logTableProvi

int batchSize = 90;

// Batches must be within a single table partition, so Key is "tableName + ParitionKey".
// Batches must be within a single table partition, so Key is "tableName + PartitionKey".
var batches = new Dictionary<string, Tuple<CloudTable, TableBatchOperation>>();

List<Task> t = new List<Task>();
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Logging/LogFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static ILogReader NewReader(ILogTableProvider logTableProvider)
/// Create a new log writer.
/// Pass in machineName to facilitate multiple compute instances writing to the same table simultaneously without interference.
/// </summary>
/// <param name="hostName">name of host. A host is a homegenous collection of compute containers, like an Azure Website / appservice.
/// <param name="hostName">name of host. A host is a homogenous collection of compute containers, like an Azure Website / appservice.
/// Multiple hosts can share a single set of azure tables. Logging is scoped per-host.</param>
/// <param name="machineName">name of the compute container. Likely %COMPUTERNAME%. </param>
/// <param name="logTableProvider">callback interface that gets invoked to get azure tables to write logging to.</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal interface IPersistentQueueReader<T>
{
/// <summary>Dequeues the next message in the queue, if any.</summary>
/// <returns>The dequeued message, if any.</returns>
/// <remarks>Dequeuing marks the message as temorarly invisible.</remarks>
/// <remarks>Dequeuing marks the message as temporarily invisible.</remarks>
Task<T> DequeueAsync();

/// <summary>Deletes a message from the queue.</summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Azure.WebJobs.Protocols/JsonSerialization.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ internal static class JsonSerialization
{
private static readonly JsonSerializerSettings JsonSerializerSettings = new JsonSerializerSettings
{
// The default value, DateParseHandling.DateTime, drops time zone information from DateTimeOffets.
// The default value, DateParseHandling.DateTime, drops time zone information from DateTimeOffsets.
// This value appears to work well with both DateTimes (without time zone information) and DateTimeOffsets.
DateParseHandling = DateParseHandling.DateTimeOffset,
NullValueHandling = NullValueHandling.Ignore,
Expand Down
Loading