Skip to content

Commit

Permalink
Resolved CR comments for document changes
Browse files Browse the repository at this point in the history
  • Loading branch information
XiaoningLiu authored and vinjiang committed Jan 15, 2019
1 parent 7ef0dbe commit e6fe50e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
10 changes: 5 additions & 5 deletions file/BreakingChanges.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

2018.01 Version 10.1.0

* Updated convenience layer methods enum type parameters into typescript union types, this will help reducing bundle footprint.
* Updated URL encoding strategy for `url` parameters of `new XXXURL(url, pipeline)` methods, such as `new FileURL(url, pipeline)`.
* URL will accept both encoded or non-encoded URL string. It will escape non-escaped special characters, like Chinese characters. However, if directory/file name includes `%`, `url` must be encoded manually.
* `SASQueryParameters` is not going to be exported in browser bundle, and will be exported in Node.js runtime.
* IE11 needs `Array.prototype.includes` and `Object.keys` polyfills loaded.
* Updated convenience layer methods enum type parameters into typescript union types, this will help reducing bundle footprint.
* Updated URL encoding strategy for `url` parameters of `new XXXURL(url, pipeline)` methods, such as `new FileURL(url, pipeline)`.
* URL will accept both encoded or non-encoded URL string. It will escape non-escaped special characters, like Chinese characters. However, if directory/file name includes `%`, `url` must be encoded manually.
* `SASQueryParameters` is not going to be exported in browser bundle, and will be exported in Node.js runtime.
* IE11 needs `Array.prototype.includes` and `Object.keys` polyfills loaded.
4 changes: 3 additions & 1 deletion file/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ This SDK is compatible with Node.js and browsers, and validated against LTS Node

You need polyfills to make this library work with IE11. The easiest way is to use [@babel/polyfill](https://babeljs.io/docs/en/babel-polyfill), or [polyfill service](https://polyfill.io/v2/docs/).
Or you can load separate polyfills for missed ES feature(s).
This library depends on following ES6 features which need external polyfills loaded.
This library depends on following ES features which need external polyfills loaded.

* `Promise`
* `String.prototype.startsWith`
* `String.prototype.endsWith`
* `String.prototype.repeat`
* `String.prototype.includes`
* `Array.prototype.includes`
* `Object.keys` (Override IE11's `Object.keys` with ES6 polyfill forcely to enable [ES6 behavior](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Notes))

#### Differences between Node.js and browsers

Expand Down
2 changes: 1 addition & 1 deletion file/lib/DirectoryURL.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class DirectoryURL extends StorageURL {
/**
* Creates a DirectoryURL object from an existing DirectoryURL.
*
* @param directoryURL A DirectoryURl object
* @param directoryURL A DirectoryURL object
* @param directoryName A subdirectory name
*/
public static fromDirectoryURL(
Expand Down

0 comments on commit e6fe50e

Please sign in to comment.