Allow 'web' as a hard coded resource name #4489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Some services hardcode names into their URLs, such as
default
here:When we construct the resource type identifier for those resources, we don't want to include those - for this example, we want
blobService/containers
notblobService/default/containers
.While importing
Microsoft.Web/sites/sourcecontrols
Nishant Shekhar encountered this error:which I traced down to the presence of the hard coded name
web
in this URL:I've refactored the code to allow for
web
as a hard coded name in addition todefault
, and to raise an error should another form of hard coded name be encountered.Special notes
I combined several existing tests into a single table test.
How does this PR make you feel?
Checklist