Idiomatic resource naming for asoctl #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
force-pushed
the
feature/idiomatic-asoctl-naming
branch
from
b289c8e to
5dc5f4e
Compare
super-harsh
approved these changes
Dec 11, 2024
| @@ -442,9 +445,10 @@ func (i *importableARMResource) getStatus( | |||
| ctx context.Context, | |||
| armID string, | |||
| importable genruntime.ImportableARMResource, | |||
| factory *importFactory, | |||
There was a problem hiding this comment.
We can pass just the scheme here rather than the whole struct?
There was a problem hiding this comment.
I have plans to tidy this further in the future, adding new methods to the factory that simplify this code further.
| ) | ||
|
|
||
| // importFactory is a helper struct that's used to create things. | ||
| type importFactory struct { |
There was a problem hiding this comment.
ImportHelper sounds like a better name to me
There was a problem hiding this comment.
I try to avoid names like Helper and Manager as they become dumping grounds for too much.
I used factory as it's used for making things, but I'm open to a better suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Within a Kubernetes Cluster, resources need to have unique names only within resources of that type - the GroupKind of the resource is part of the uniqueness key.
This allows us to change
asoctlto simply reuse the last part of the ARM ID for each resource as the name in most cases.To disambiguate when multiple resources have the same "name" and collide, we add a unique random suffix as required. In testing, this happened rarely.
Closes #4349
How does this PR make you feel?
Checklist