-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for diagnosticSettings #4363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really solid, good job. I made a few comments to improve your test, and you need to make a recording of your sample, but other than that it's very nearly complete.
v2/internal/controllers/insights_diagnosticsetting_crud_v20210501preview_test.go
Outdated
Show resolved
Hide resolved
v2/internal/controllers/insights_diagnosticsetting_crud_v20210501preview_test.go
Outdated
Show resolved
Hide resolved
v2/internal/controllers/insights_diagnosticsetting_crud_v20210501preview_test.go
Outdated
Show resolved
Hide resolved
v2/internal/controllers/insights_diagnosticsetting_crud_v20210501preview_test.go
Outdated
Show resolved
Hide resolved
v2/samples/insights/v1api/v1api20210501preview_diagnosticsetting.yaml
Outdated
Show resolved
Hide resolved
/ok-to-test sha=e7174dd |
1 similar comment
/ok-to-test sha=e7174dd |
66e5c22
to
28a97cf
Compare
CI is failing because you're missing an update to one file - Once that's included, we can run the full test suite and look at merging this contribution. Thanks! Spoiler alert: I ran the full test suite locally, and it passed. 😉 |
@theunrepentantgeek Thanks for the valuable feedbacks. Added the missing updates to the file - |
/ok-to-test sha=2be47b4 |
/ok-to-test sha=27a974c |
A couple of markdown files are generating with different content, looks like the generator is now picking up on the sample and is including links in the index files. I've confirmed this locally: $ git status
On branch feature/diagnosticsetting
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: docs/hugo/content/reference/_index.md
modified: docs/hugo/content/reference/insights/_index.md Run |
Ran the above mentioned command and committed the changes 0f45678 |
/ok-to-test sha=0f45678 |
Thanks @nishant221, great contribution. |
Closes #4248
What this PR does / why we need it:
Add support for a new resource
DiagnosticSetting
Special notes for your reviewer:
How does this PR make you feel:
Excited :)
If applicable: