Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genruntime support for Dynamic secrets and configmap exports #4314

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Oct 1, 2024

Part of #2555.

See the design here

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr
Copy link
Member Author

matthchr commented Oct 1, 2024

/ok-to-test sha=326c513

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good foundation. A couple of minor comments, keen to see the next step.

v2/pkg/genruntime/configmaps/validation.go Outdated Show resolved Hide resolved
v2/pkg/genruntime/configmaps/validation.go Outdated Show resolved Hide resolved
v2/pkg/genruntime/configmaps/validation.go Show resolved Hide resolved
v2/pkg/genruntime/configmaps/validation.go Show resolved Hide resolved
@matthchr matthchr force-pushed the feature/genruntime-dynamic-export branch from 326c513 to ecb2a01 Compare October 2, 2024 19:11
@matthchr
Copy link
Member Author

matthchr commented Oct 2, 2024

/ok-to-test sha=ecb2a01

@matthchr matthchr added this pull request to the merge queue Oct 2, 2024
Merged via the queue into Azure:main with commit cb5ffca Oct 2, 2024
7 checks passed
@matthchr matthchr deleted the feature/genruntime-dynamic-export branch October 2, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants