-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue templates #4305
Update issue templates #4305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, LMK what you think
@@ -7,4 +7,6 @@ assignees: '' | |||
|
|||
--- | |||
|
|||
<Describe the feature request> | |||
## Feature Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a heading here? We've already got the feature tag auto-added and the issue starts with Feature:
, also saying ## Feature request
at the top seems unneeded (to me).
Maybe just change from <>
to _
and leave the rest of this one as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a minor comment on contribution
<Describe the feature request> | ||
_Describe the feature request._ | ||
|
||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think its worth mentioning the link to contribution guide here and encourage users to contribute if they want to?
What this PR does
Updates our issue templates to use markdown headings and to clarify the language.
Special notes for your reviewer
Our existing templates have been irritating me, so trying to make them better.
How does this PR make you feel