-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASOv1 to ASOv2 migration guide #3898
Conversation
Once you've applied the above, make sure to update your applications to depend on the new secret | ||
written by ASOv2. | ||
|
||
TODO: How to work around connection string issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear up this TODO
b21326a
to
1db5383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks extremely good! I've commented on some nitpicks but overall this is solid.
> You can run `helm upgrade` and pass `--set certManagerResourcesAPIVersion=cert-manager.io/v1` to ensure ASOv1 is using | ||
> the v1 versions of the cert-manager resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do an upgrade, or just return an error if non v1 versions are in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends a bit on what you mean by "upgrade". It doesn't change the versions of any resources in the cluster (container images, helm charts, etc), at least assuming you use the same version of the ASOv1 chart as you already have installed. What it does is delete the ASOv1 v1alpha2
cert-manager CRs and replace them with v1
cert-manager CRs.
So the net effect of this is:
- Delete v1alpha2 cert manager custom resources (not the CRDs, the CRs)
- Create v1 cert manager custom resources w/ same configuration as above.
|
||
### Stop ASOv1 reconciliation | ||
|
||
Mark each ASOv1 resource with the `skipreconcile=true` annotation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be hard to add and remove annotation on each resource.
Should have a way in ASOv2 to pause reconciliation at the controller level for all resources, if not already there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give commands just below of how to do it for a whole namespace at once. It's a one-liner so I don't think we need any other features. At most, we could make an asoctl
feature to do the one-line like asoctl annotate all
or something, but I don't think it's needed atm really.
1db5383
to
6e384fe
Compare
/ok-to-test sha=6e384fe |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/ok-to-test sha=6e384fe |
Fixes #3006
Fixes #3342
If applicable: