Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASO v2 dependency updates #3393

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Oct 9, 2023

What this PR does / why we need it:

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@matthchr
Copy link
Member Author

matthchr commented Oct 9, 2023

/ok-to-test sha=4a7f74d

@matthchr matthchr force-pushed the feature/v2-dependencies branch from 4a7f74d to 46a1a56 Compare October 9, 2023 23:18
@matthchr
Copy link
Member Author

matthchr commented Oct 9, 2023

/ok-to-test sha=46a1a56

@codecov-commenter
Copy link

Codecov Report

Merging #3393 (46a1a56) into main (7c28a18) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main    #3393   +/-   ##
=======================================
  Coverage   54.49%   54.50%           
=======================================
  Files        1515     1515           
  Lines      636546   636546           
=======================================
+ Hits       346899   346949   +50     
+ Misses     232996   232938   -58     
- Partials    56651    56659    +8     
Files Coverage Δ
v2/internal/genericarmclient/generic_client.go 57.77% <60.00%> (-0.45%) ⬇️

... and 30 files with indirect coverage changes

@matthchr matthchr enabled auto-merge (squash) October 10, 2023 00:08
Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to go.mod for the controller often require a similar change for asoctl, would be worth checking. Otherwise looks good.

@matthchr matthchr merged commit c267abd into Azure:main Oct 10, 2023
8 checks passed
@matthchr matthchr deleted the feature/v2-dependencies branch May 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants