Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go-Get, take II #3380

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update Go-Get, take II #3380

merged 1 commit into from
Oct 6, 2023

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Often the go get step in our CI builds will fail.

This is due to delays in the default proxy used by the go CLI, specifically:

In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute.

Special notes for your reviewer:

Bypassing the proxy would invalidate the scenario we want to test, so I've juiced up the retries.

How does this PR make you feel:
gif

@codecov-commenter
Copy link

Codecov Report

Merging #3380 (14bdbf8) into main (64714e3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   54.51%   54.49%   -0.02%     
==========================================
  Files        1515     1515              
  Lines      636546   636546              
==========================================
- Hits       346982   346895      -87     
- Misses     232908   232989      +81     
- Partials    56656    56662       +6     

see 32 files with indirect coverage changes

echo "Failed to 'go get' $repo/v2@$sha, retrying in 10 seconds…"
sleep 10
echo "Failed to 'go get' $repo/v2@$sha, retrying in 60 seconds…"
sleep 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should monitor how long this takes, because if it actually is taking anywhere near 5m we should probably just strip this bit out into its own async check rather than putting it here. Adding +5m to the CI run would ideally be avoided.

@matthchr matthchr merged commit 7c28a18 into main Oct 6, 2023
@matthchr matthchr deleted the fix/go-get-v2 branch October 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants